Skip to content

Commit 1679be3

Browse files
Lukas742Lukas742
authoredOct 23, 2024··
fix(Toolbar): announce number of items in overflow popover (#6544)
Fixes #5926 Also downports all translations.
1 parent 6fc5199 commit 1679be3

File tree

64 files changed

+638
-289
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+638
-289
lines changed
 

‎packages/main/src/components/AnalyticalTable/AnalyticalTable.cy.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -2159,13 +2159,13 @@ describe('AnalyticalTable', () => {
21592159
cy.get('[data-visible-row-index="1"][data-visible-column-index="0"]').should(
21602160
'have.attr',
21612161
'aria-label',
2162-
'Name A Grouped, To expand the row, press the spacebar'
2162+
'Name A Grouped, To expand the row, press the spacebar.'
21632163
);
21642164
cy.get('[name="navigation-right-arrow"]').click();
21652165
cy.get('[data-visible-row-index="1"][data-visible-column-index="0"]').should(
21662166
'have.attr',
21672167
'aria-label',
2168-
'Name A Grouped, To collapse the row, press the spacebar'
2168+
'Name A Grouped, To collapse the row, press the spacebar.'
21692169
);
21702170
cy.findByText('Name').click();
21712171
cy.findByText('Ungroup').shadow().findByRole('listitem').click({ force: true });

‎packages/main/src/components/DynamicPage/DynamicPage.stories.tsx

+47-29
Original file line numberDiff line numberDiff line change
@@ -60,23 +60,23 @@ const meta = {
6060
<DynamicPageTitle
6161
actions={
6262
<>
63-
<Button key={'edit'} design={ButtonDesign.Emphasized}>
63+
<Button data-accessible-name key={'edit'} design={ButtonDesign.Emphasized}>
6464
Edit
6565
</Button>
66-
<Button key={'delete'} design={ButtonDesign.Transparent}>
66+
<Button data-accessible-name key={'delete'} design={ButtonDesign.Transparent}>
6767
Delete
6868
</Button>
69-
<Button key={'copy'} design={ButtonDesign.Transparent}>
69+
<Button data-accessible-name key={'copy'} design={ButtonDesign.Transparent}>
7070
Copy
7171
</Button>
72-
<Button key={'action'} icon={actionIcon} design={ButtonDesign.Transparent} />
72+
<Button data-accessible-name key={'action'} icon={actionIcon} design={ButtonDesign.Transparent} />
7373
</>
7474
}
7575
navigationActions={
7676
<>
77-
<Button key={'fullscreen'} icon={fullscreenIcon} design={ButtonDesign.Transparent} />
78-
<Button key={'exitFullscreen'} icon={exitFSIcon} design={ButtonDesign.Transparent} />
79-
<Button key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />
77+
<Button data-accessible-name key={'fullscreen'} icon={fullscreenIcon} design={ButtonDesign.Transparent} />
78+
<Button data-accessible-name key={'exitFullscreen'} icon={exitFSIcon} design={ButtonDesign.Transparent} />
79+
<Button data-accessible-name key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />
8080
</>
8181
}
8282
breadcrumbs={
@@ -158,10 +158,10 @@ export const WithVariants: Story = {
158158
<Button key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />
159159
]);
160160
const [actionItems, setActionItems] = useState([
161-
<Button key={'edit'} design={ButtonDesign.Emphasized}>
161+
<Button data-accessible-name key={'edit'} design={ButtonDesign.Emphasized}>
162162
Edit
163163
</Button>,
164-
<Button key={'delete'} design={ButtonDesign.Transparent}>
164+
<Button data-accessible-name key={'delete'} design={ButtonDesign.Transparent}>
165165
Delete
166166
</Button>
167167
]);
@@ -171,27 +171,37 @@ export const WithVariants: Story = {
171171
setNavigationItems(
172172
selectedVariant === 'Header Variant 2'
173173
? [
174-
<Button key={'fullscreen'} icon={fullscreenIcon} design={ButtonDesign.Transparent} />,
175-
<Button key={'exitFullscreen'} icon={exitFSIcon} design={ButtonDesign.Transparent} />,
176-
<Button key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />
174+
<Button
175+
data-accessible-name
176+
key={'fullscreen'}
177+
icon={fullscreenIcon}
178+
design={ButtonDesign.Transparent}
179+
/>,
180+
<Button
181+
data-accessible-name
182+
key={'exitFullscreen'}
183+
icon={exitFSIcon}
184+
design={ButtonDesign.Transparent}
185+
/>,
186+
<Button data-accessible-name key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />
177187
]
178-
: [<Button key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />]
188+
: [<Button data-accessible-name key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />]
179189
);
180190
setActionItems(
181191
selectedVariant === 'Header Variant 1'
182192
? [
183-
<Button key={'edit'} design={ButtonDesign.Emphasized}>
193+
<Button data-accessible-name key={'edit'} design={ButtonDesign.Emphasized}>
184194
Edit
185195
</Button>,
186-
<Button key={'delete'} design={ButtonDesign.Transparent}>
196+
<Button data-accessible-name key={'delete'} design={ButtonDesign.Transparent}>
187197
Delete
188198
</Button>
189199
]
190200
: [
191-
<Button key={'copy'} design={ButtonDesign.Transparent}>
201+
<Button data-accessible-name key={'copy'} design={ButtonDesign.Transparent}>
192202
Copy
193203
</Button>,
194-
<Button key={'action'} icon={actionIcon} design={ButtonDesign.Transparent} />
204+
<Button data-accessible-name key={'action'} icon={actionIcon} design={ButtonDesign.Transparent} />
195205
]
196206
);
197207
};
@@ -287,30 +297,38 @@ export const WithCustomOverflowButton: Story = {
287297
},
288298
actions: (
289299
<>
290-
<Button key={'edit'} design={ButtonDesign.Emphasized}>
300+
<Button data-accessible-name key={'edit'} design={ButtonDesign.Emphasized}>
291301
Edit
292302
</Button>
293-
<Button key={'delete'} design={ButtonDesign.Transparent}>
303+
<Button data-accessible-name key={'delete'} design={ButtonDesign.Transparent}>
294304
Delete
295305
</Button>
296-
<Button key={'copy'} design={ButtonDesign.Transparent}>
306+
<Button data-accessible-name key={'copy'} design={ButtonDesign.Transparent}>
297307
Copy
298308
</Button>
299-
<Button key={'action'} icon={actionIcon} design={ButtonDesign.Transparent}>
309+
<Button data-accessible-name key={'action'} icon={actionIcon} design={ButtonDesign.Transparent}>
300310
Action
301311
</Button>
302-
<Button design={ButtonDesign.Transparent}>Create</Button>
303-
<Button design={ButtonDesign.Transparent}>Loooooong actions Button</Button>
312+
<Button data-accessible-name design={ButtonDesign.Transparent}>
313+
Create
314+
</Button>
315+
<Button data-accessible-name design={ButtonDesign.Transparent}>
316+
Loooooong actions Button
317+
</Button>
304318
</>
305319
),
306320
navigationActions: (
307321
<>
308-
<Button key={'fullscreen'} icon={fullscreenIcon} design={ButtonDesign.Transparent} />
309-
<Button key={'exitFullscreen'} icon={exitFSIcon} design={ButtonDesign.Transparent} />
310-
<Button key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />
311-
<Button design={ButtonDesign.Transparent}>UI5 Web Components For React</Button>
312-
<Button design={ButtonDesign.Transparent}>Navigation Actions Button</Button>
313-
<Button design={ButtonDesign.Transparent}>
322+
<Button data-accessible-name key={'fullscreen'} icon={fullscreenIcon} design={ButtonDesign.Transparent} />
323+
<Button data-accessible-name key={'exitFullscreen'} icon={exitFSIcon} design={ButtonDesign.Transparent} />
324+
<Button data-accessible-name key={'decline'} icon={declineIcon} design={ButtonDesign.Transparent} />
325+
<Button data-accessible-name design={ButtonDesign.Transparent}>
326+
UI5 Web Components For React
327+
</Button>
328+
<Button data-accessible-name design={ButtonDesign.Transparent}>
329+
Navigation Actions Button
330+
</Button>
331+
<Button data-accessible-name design={ButtonDesign.Transparent}>
314332
Loooooooooooooooooooooooooooooooooooong navigation actions Button
315333
</Button>
316334
</>

0 commit comments

Comments
 (0)