[matmul code] First non-naive test fails

[flying-sheep]

rust-gpu.github.io/blog/2024-11-25-optimizing-matmul/code/bin/blog/src/bin.rs

Line 88 in 24cb6e9

run_test(matmul, size);

Fails for me with

Mismatch at [0, 1]: expected 22839525000, got 22839521000

I’m on Linux with a AMD Radeon RX 6800 XT

[flying-sheep]

Here’s an ANSI-colored debug.log

[LegNeato]

Thanks! I will hopefully look into it later this week if other people don't get to it

[flying-sheep]

That would be great!

The example can also be updated to the newest main branch revision, making it able to use a newer Rust nightly and removes the need for this hack, I think:

rust-gpu.github.io/blog/2024-11-25-optimizing-matmul/code/Cargo.toml

Lines 56 to 69 in 24cb6e9

	# This is the default but without explicitly specifying it, Cargo
	# will treat the identical settings in `[profile.release.build-override]` below
	# as different sets of `rustc` flags and will not reuse artifacts between them.
	codegen-units = 256
	# Compile build-dependencies in release mode with the same settings as regular
	# dependencies (including the incremental enabled above).
	#
	# We need this to templorarily work around
	# https://github.com/Rust-GPU/rust-gpu/issues/29.
	[profile.release.build-override]
	opt-level = 3
	incremental = true
	codegen-units = 256

Question: When running the example, it always rebuilds the GPU crates for me. Is there a way to have cargo cache them?

[LegNeato]

Latest rust-gpu is #75

[LegNeato]

Can you open a bug for the rebuilds? We are emitting cargo metadata so it shouldn't always rebuild but I may have messed something up.

[flying-sheep]

In Rust-GPU or here?

This is what rebuilds:

   Compiling compiled_isomorphic v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/isomorphic)
   Compiling compiled_workgroup_2d v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/workgroup_2d)
   Compiling compiled_tiling_1d_loop v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/tiling_1d_loop)
   Compiling compiled_tiling_2d v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/tiling_2d)
   Compiling compiled_workgroup_256 v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/workgroup_256)
   Compiling compiled_tiling_1d v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/tiling_1d)
   Compiling compiled_naive v0.1.0 (/home/phil/Dev/Rust-GPU matmul kernel/crates/cpu/compiled_for_gpu/naive)
    Building [======================>  ] 257/273: compiled_tiling_1d(build), compiled_workgroup_256(build), compiled_naive(build), compiled_tiling_1d_loop(build), compiled_isomorphic(build), compiled_tiling_2d(build), compiled_workgroup_2d(build)                                                                                 

[LegNeato]

Here, it shouldn't be rebuilding

[flying-sheep]

done! #79