Skip to content

Commit d28c8fc

Browse files
authored
Revert edit_config signature updates in ansible-collections#653 (ansible-collections#640)
* Revert edit_config signature updates in ansible-collections#653 Signed-off-by: NilashishC <[email protected]> * Add changelog Signed-off-by: NilashishC <[email protected]> * Revert RMBase changes Signed-off-by: NilashishC <[email protected]> --------- Signed-off-by: NilashishC <[email protected]>
1 parent 569f662 commit d28c8fc

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

changelogs/fragments/bug_653.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
---
2+
bugfixes:
3+
- The v6.1.2 release introduced a change in cliconfbase's edit_config() signature which broke many platform cliconfs. This patch would revert that change.

plugins/module_utils/network/common/rm_base/resource_module.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,9 @@ def compare(self, parsers, want=None, have=None):
145145
else:
146146
self.addcmd(have, parser, True)
147147

148-
def run_commands(self, err_responses=None):
148+
def run_commands(self):
149149
"""Send commands to the device"""
150150
if self.commands and self.state in self.ACTION_STATES:
151151
if not self._module.check_mode:
152-
self._connection.edit_config(candidate=self.commands, err_responses=err_responses)
152+
self._connection.edit_config(candidate=self.commands)
153153
self.changed = True

plugins/plugin_utils/cliconf_base.py

-3
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,6 @@ def edit_config(
215215
replace=None,
216216
diff=False,
217217
comment=None,
218-
err_responses=None,
219218
):
220219
"""Loads the candidate configuration into the network device
221220
@@ -235,8 +234,6 @@ def edit_config(
235234
the file in this case should be present on the remote host in the mentioned path as a
236235
prerequisite.
237236
:param comment: Commit comment provided it is supported by remote host.
238-
:param err_responses: A list of error regexes that will be used to evaluate the responses received
239-
from executing the candidate command(s).
240237
:return: Returns a json string with contains configuration applied on remote host, the returned
241238
response on executing configuration commands and platform relevant data.
242239
{

0 commit comments

Comments
 (0)