We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fossify.js
The fossify.js script currently has a few issues that need to be addressed:
Deprecated fs.rmdir Usage
fs.rmdir
fs.rm
Lack of Error Handling for fs.unlink
fs.unlink
./apps/meteor/startRocketChat.ts
fs.access
Lack of Error Handling for fs.rename
fs.rename
./apps/meteor/startRocketChatFOSS.ts
try-catch
Unclear Error Handling in fossify()
fossify()
if (!e)
"Unknown error"
console.error(e.message)
./ee
./apps/meteor/ee
I have already submitted a pull request. Kindly do not work on it
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Bug Report: Fix Deprecated Methods and Improve Error Handling in
fossify.js
Description
The
fossify.js
script currently has a few issues that need to be addressed:Deprecated
fs.rmdir
Usagefs.rmdir
is deprecated in Node.js 14+ and should be replaced withfs.rm
for better compatibility.fs.rmdir
withfs.rm
.Lack of Error Handling for
fs.unlink
./apps/meteor/startRocketChat.ts
does not exist,fs.unlink
will throw an error, stopping the script.fs.access
to check if the file exists before attempting to delete it.Lack of Error Handling for
fs.rename
./apps/meteor/startRocketChatFOSS.ts
does not exist,fs.rename
will fail and crash the script.fs.rename
in atry-catch
block and provide a proper error message.Unclear Error Handling in
fossify()
if (!e)
, which may not properly catch all cases."Unknown error"
, log the error properly usingconsole.error(e.message)
.Steps to Reproduce
./ee
or./apps/meteor/ee
does not exist../apps/meteor/startRocketChat.ts
is missing, the script will crash whenfs.unlink
is called../apps/meteor/startRocketChatFOSS.ts
is missing, the script will fail atfs.rename
.Expected Behavior
fs.rm
instead offs.rmdir
.I have already submitted a pull request. Kindly do not work on it
The text was updated successfully, but these errors were encountered: