Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use db instead of client in startTracing function #35409

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: use db instead of client in startTracing function #35409

wants to merge 3 commits into from

Conversation

naman22a
Copy link

@naman22a naman22a commented Mar 6, 2025 •
edited
Loading

fix: use db instead of client in startTracing function

Description

This PR updates the startTracing function to use the db variable instead of client for better consistency and code clarity.

Changes Made

  • Replaced client with db in the startTracing function.

Before
startTracing({ service: '<%= name %>', db: client });
After
startTracing({ service: '<%= name %>', db: db });

Issue(s)

Fixes #35408

@naman22a naman22a requested a review from a team as a code owner March 6, 2025 10:41
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 6, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@naman22a
Copy link
Author

naman22a commented Mar 6, 2025

Sorry is it fine now ? , this is my first contribution

@naman22a naman22a changed the title fix : client is undefined in startTracing() in service.ts fix: use db instead of client in startTracing function Mar 6, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2a0be39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix : client is undefined in startTracing() in service.ts
3 participants
@naman22a @CLAassistant @ggazzo