Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Custom Status Empty String Issue & Inconsistent Status Button Behavior #35379

Open
jjinendra3 opened this issue Mar 1, 2025 · 4 comments

Comments

@jjinendra3
Copy link

jjinendra3 commented Mar 1, 2025

Description:

There are two major inconsistencies in how custom status updates work in the web client:

🐛 Issues Identified:

  1. Empty Custom Status ("") Behavior:

    • When a user sets their custom status as an empty string (""), a toast message appears confirming that the status has been updated.
    • However, in reality, the status does not get updated, meaning the server rejects the empty value (""), but the UI does not reflect this rejection.
  2. Inconsistent Status Button Behavior:

    • When selecting status options like "Online," "Busy," "Away," or "Offline", only the status icon updates, but the textual custom status remains unchanged.
    • However, selecting "Meeting" does update the textual custom status to "Meeting".
    • This inconsistency makes the user experience confusing and should be fixed for consistency.

Steps to reproduce:

  1. Click on your profile icon.
  2. Click on meeting status, changing the status to meeting and then do the below, if not set at meeting, the function works fine.
  3. Checkout various status options, they only change the status icon but not the text.
  4. The meeting button does change the text to meeting.
  5. Go to custom status, and make the input field blank (i.e. delete fetched status text).
  6. Submit, you will receive success toast.
  7. Again open the custom status modal, you will see that youre status is the same that you wanted to delete.

Expected behavior:

  1. For Empty Custom Status ("") Issue:

    • Either prevent the user from submitting an empty status OR
    • Show a toast message stating: "Custom status cannot be empty."
    • Alternatively, if keeping an empty status is valid, the server should allow it.
  2. For Status Button Consistency:

    • All status buttons (Online, Busy, Away, Offline, Meeting) should update both the status icon and the textual custom status, ensuring consistent behavior.

Actual behavior:

20250301-1049-17.7560462.mp4

Server Setup Information:

  • Testing on Prod

Client Setup Information

  • Desktop App or Browser Version:Browser
  • Operating System: WSL

Additional context

Relevant logs:

@reetp
Copy link

reetp commented Mar 2, 2025

Can you check and have a really good search, including closed issues, as I seem to remember similar recently.

@Kartikayy007
Copy link

I think its #35294 it has PR opened already

@reetp
Copy link

reetp commented Mar 4, 2025

I think its #35294 it has PR opened already

I believe that is regarding saves on an app and bug 35391. It is not the same as this.

I can't find anything so will ask for a review.

@jjinendra3
Copy link
Author

jjinendra3 commented Mar 5, 2025

I think its #35294 it has PR opened already

I believe that is regarding saves on an app and bug 35391. It is not the same as this.

I can't find anything so will ask for a review.

Couldn't find a similar issue either, thanks for putting it on review. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants