Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen share does not work on RocketChat Electron #2992

Open
4 of 5 tasks
moell9 opened this issue Feb 19, 2025 · 7 comments
Open
4 of 5 tasks

Screen share does not work on RocketChat Electron #2992

moell9 opened this issue Feb 19, 2025 · 7 comments

Comments

@moell9
Copy link

moell9 commented Feb 19, 2025

Search before asking

  • I had searched in the issues and found no similar issues.

Operating System

  • macOS
  • Windows
  • Linux

Operating System Version

No response

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

4.1.2

Rocket.Chat Server Version

7.3.1

Describe the bug

Please see here: RocketChat/Rocket.Chat#35110

How to Reproduce

Just try to share a screen or a window.

Describe your Expected behavior

No response

Anything else

No response

Are you willing to submit a code contribution?

  • Yes, I am willing to submit a Pull Request!
@reetp
Copy link

reetp commented Feb 19, 2025

You state in RocketChat/Rocket.Chat#35110

We disabled Open Video Chat using Application Window. And then in Chrome we can share the screen or a window.

And according to this it looks like it needs an update to the underlying Electron SDK, and Jitsi itself. So it's going to be a while before you get a fix and you have a workaround for now.

jitsi/jitsi-meet#15574 (comment)

I'll ask the team for comments.

@friedrichkeydel
Copy link

According to the latest answer in jitsi/jitsi-meet#15574 (comment), it should be fixed by updating the Electron SDK to version 7.

@rgoerner
Copy link

rgoerner commented Mar 4, 2025

Does anyone from the staff of rocketchat knows, when this will be fixed on the Rocketchat Clients?
We have a paid subscription, would be nice, if it could work again. Thanks

@reetp
Copy link

reetp commented Mar 4, 2025

Does anyone from the staff of rocketchat knows, when this will be fixed on the Rocketchat Clients?

When it gets done. It has to go through multiple layers and departments and I would expect it normally would take a couple of release cycles at least, depending on other priorities.

We have a paid subscription, would be nice, if it could work again. Thanks

In which case you should use the correct channel which is support, and raise an issue there. You can quote this Issue as a reference.

Note that Github is really just the released end product. It is not the primary source of code or issues for Rocket. That is what paid support and the ticketing system is for.

@moell9
Copy link
Author

moell9 commented Mar 7, 2025

The new update is frustrating, sorry to say this.

@moell9
Copy link
Author

moell9 commented Mar 7, 2025

I'm in contact with people from Jitsi.
They say and ask:
There is a fallback mechanism that should kick in. What Electron SDK and Jitsi Meet versions do they use?

@saghul
Copy link

saghul commented Mar 7, 2025

👋 Hey there Saúl from Jitsi here.

Looks like RocketChat is not using the Jitsi Electron SDK (https://github.com/jitsi/jitsi-meet-electron-sdk) but rather including the piece of code that made screen-sharing work directly.

This had the unfortunate consequence of RC missing on the SDK updates that migrated the way to do this "the right way".

We are on the 3rd (and hopefully final, since we are now using getDisplayMedia, like browsers) of screen-sharing.

RC currently implements the old-old mechanis, which we dropped after we added the latest one. We still keep compatibility with the old one, but not with the old-old one that required injecting a global in the render process.

In both the old and the new the mechanism relies on the external API for signalling the sources.

I'd suggest using the SDK so you can get these updates going forward.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants