Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Allow Direct String Input for Model Name Instead of Predefined Select Option #3

Open
sushen123 opened this issue Mar 8, 2025 · 3 comments

Comments

@sushen123
Copy link

Currently, the configuration for the MODEL_TYPE setting uses SettingType.SELECT with predefined model values, such as "meta-llama/Llama-3.2-11B-Vision-Instruct". This approach limits flexibility because different providers might use different model names for the same model. Instead, we can use a direct string input for the model name.

if this valid, i want to work on this issue.

@Sing-Li
Copy link
Member

Sing-Li commented Mar 8, 2025

Do you mean cloning RocketChat/Apps.Chat.Summarize#17 over to this project?

@sushen123
Copy link
Author

sushen123 commented Mar 8, 2025

Do you mean cloning RocketChat/Apps.Chat.Summarize#17 over to this project?

No sir, I just want to implement type string instead of select because i find "meta-llama/Llama-3.2-11B-Vision-Instruct", for this same model different provider are using different model name.

We can clone that feature too, if you want?

@Sing-Li
Copy link
Member

Sing-Li commented Mar 8, 2025

Great intention 🙏 But I don't think we should do anything in this area AT THIS POINT IN TIME.

Because it is not too difficult to every contributor working with it to change the code if needed.

Adding this code now can also confuse new contributors since it introduces a baggage that has nothing to do with the purpose/objective of this project.

I am not going to close this, but just leave it here for contributors to implement after we have a fixed working core / direction. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants