Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate GUI to Qt6 #1329

Open
2 tasks
martukas opened this issue Apr 3, 2023 · 1 comment · May be fixed by #1330
Open
2 tasks

Migrate GUI to Qt6 #1329

martukas opened this issue Apr 3, 2023 · 1 comment · May be fixed by #1330
Labels
GUI Graphical User Interface project Software Umbrella: GUI, Controller or CI
Milestone
Goalpost v0.5

Comments

@martukas
Copy link
Member

martukas commented Apr 3, 2023

What has to be done
We need to migrate our GUI code from Qt5 to Qt6.

Subtasks:

  • Some of the API will have changed, so some reworking of the code will be necessary.
  • Probably need to get rid of qnanopainter. It does not support Qt6 and they don't seem to have plans for it in the future. Furthermore, Qt6 supports OpenGL accelerated rendering out of the box, so this library should not be needed.

How do you know it has to be done
Qt5 will not be officially supported past May 2023, which is coming up quite soon. We should get ahead of this.

Starting points
Just do it!

Don't forget (can delete these when done)

  • Put the issue in a milestone
  • Assign it to one of the projects
  • Add appropriate labels
  • Mention dependent/blocked issues if any
@martukas martukas added GUI Graphical User Interface project Software Umbrella: GUI, Controller or CI labels Apr 3, 2023
martukas added a commit that referenced this issue Apr 3, 2023
@martukas
removed qnanoplotter, bumped to qt6 - builds, but does not render; up…
45cb7fa 
…dates #1329
martukas added a commit that referenced this issue Apr 3, 2023
@martukas
cleanup and install scripts for qt6; updates #1329
37c3b4b
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
qml type error fixed for AlarmPriority; updates #1329
85d77d1
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
no qt in conan; updates #1329
59ff82d
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
yes qt in conan; updates #1329
1913b92
@martukas martukas linked a pull request Apr 4, 2023 that will close this issue
Draft
13 tasks
@martukas
Copy link
Member Author

martukas commented Apr 4, 2023

Currently RaspberryPi OS does not have apt packages for Qt6. There are instructions out there for how to cross-compile Qt6 for Raspi, but this is a pretty complicated and involved process and it may be quite the burden to take on scripting this and maintaining it. My current judgement is that we should wait for Raspi to officially support Qt6 and only then migrate.

martukas added a commit that referenced this issue Apr 4, 2023
@martukas
removed qnanoplotter, bumped to qt6 - builds, but does not render; up…
60b119b 
…dates #1329
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
cleanup and install scripts for qt6; updates #1329
ba2f0c8
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
qml type error fixed for AlarmPriority; updates #1329
23a55ba
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
no qt in conan; updates #1329
e11ab55
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
yes qt in conan; updates #1329
41c61b9
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
got rid of qnanopainter; updates #1329
2f88200
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
works!; updates #1329
b742a14
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
refactoring and cleanup; updates #1329
daed3b7
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
removed qnanoplotter, bumped to qt6 - builds, but does not render; up…
06b93ae 
…dates #1329
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
cleanup and install scripts for qt6; updates #1329
66b2be6
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
qml type error fixed for AlarmPriority; updates #1329
91dd33a
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
no qt in conan; updates #1329
07e9324
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
yes qt in conan; updates #1329
93d2658
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
no need to deal with submodules in build scripts; updates #1329
48bd3dc
martukas added a commit that referenced this issue Apr 4, 2023
@martukas
gui demo desktop shortcut; updates #1329
2e98d94
martukas added a commit that referenced this issue Apr 11, 2023
@martukas
reenabled time_series_graph tests; updates #1329
da86931
martukas added a commit that referenced this issue Apr 11, 2023
@martukas
Remove qnanopainter submodule (#1331)
95ce947 
* got rid of qnanopainter; updates #1329

* works!; updates #1329

* refactoring and cleanup; updates #1329

* no need to deal with submodules in build scripts; updates #1329

* gui demo desktop shortcut; updates #1329

* reenabled time_series_graph tests; updates #1329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GUI Graphical User Interface project Software Umbrella: GUI, Controller or CI
Projects
None yet
Milestone
Goalpost v0.5
Development

Successfully merging a pull request may close this issue.

Migrate GUI to Qt6 RespiraWorks/Ventilator
1 participant
@martukas