Skip to content

Commit 9d19147

Browse files
committed
Allow tests to run in PHP 8.3
1 parent eee8eb2 commit 9d19147

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

.github/workflows/ci.yml

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
- ubuntu-20.04
1616
- windows-2019
1717
php:
18+
- 8.3
1819
- 8.2
1920
- 8.1
2021
- 8.0

src/Testing/Recorded.php

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66

77
class Recorded
88
{
9+
private $time;
10+
private $value;
11+
private $comparer;
12+
913
public function __construct(int $time, $value, callable $comparer = null)
1014
{
1115
$this->time = $time;

test/Rx/Scheduler/ImmediateSchedulerTest.php

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public function now_returns_the_time()
2424
public function non_zero_delay_throws()
2525
{
2626
$this->expectException(\Exception::class);
27-
$this->expectDeprecationMessage('ImmediateScheduler does not support a non-zero delay.');
2827
$scheduler = new ImmediateScheduler();
2928

3029
$scheduler->schedule(function () {

test/Rx/SchedulerTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ private function resetStaticScheduler()
1616
foreach (['default', 'async', 'immediate', 'defaultFactory', 'asyncFactory'] as $propertyName) {
1717
$prop = $ref->getProperty($propertyName);
1818
$prop->setAccessible(true);
19-
$prop->setValue(null);
19+
$ref->setStaticPropertyValue($propertyName, null);
2020
$prop->setAccessible(false);
2121
}
2222
}

0 commit comments

Comments
 (0)