Merge pull request #39 from abersnaze/long-pattern

Fixed a bug where long patterns across chunks were not found.

Author: abersnaze

src/main/java/rx/observables/StringObservable.java

@@ -423,10 +423,10 @@ public void onError(Throwable e) {
 
                     @Override
                     public void onNext(String segment) {
+                        if (leftOver != null)
+                            segment = leftOver + segment;
                         String[] parts = pattern.split(segment, -1);
 
-                        if (leftOver != null)
-                            parts[0] = leftOver + parts[0];
                         for (int i = 0; i < parts.length - 1; i++) {
                             String part = parts[i];
                             output(part);

src/test/java/rx/observables/StringObservableTest.java

@@ -17,6 +17,7 @@
 
 import static org.junit.Assert.assertArrayEquals;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotSame;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
@@ -46,6 +47,7 @@
 import java.nio.charset.CharsetDecoder;
 import java.nio.charset.MalformedInputException;
 import java.util.Arrays;
+import java.util.Iterator;
 import java.util.List;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
@@ -178,6 +180,16 @@ public void testSplit(String message, String regex, int limit, Observable<String
         AssertObservable.assertObservableEqualsBlocking("when input is " + message
                 + " and limit = " + limit, exp, act);
     }
+    
+    @Test
+    public void testSplitLongPattern() {
+        Iterator<String> iter = StringObservable.split(Observable.just("asdfqw","erasdf"), "qwer").toBlocking().getIterator();
+        assertTrue(iter.hasNext());
+        assertEquals("asdf", iter.next());
+        assertTrue(iter.hasNext());
+        assertEquals("asdf", iter.next());
+        assertFalse(iter.hasNext());
+    }
 
     @Test
     public void testJoinMixed() {