Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused properties in input and output structs #343

Open
1 of 7 tasks
alexhroom opened this issue Feb 12, 2025 · 0 comments
Open
1 of 7 tasks

Unused properties in input and output structs #343

alexhroom opened this issue Feb 12, 2025 · 0 comments
Milestone

Comments

@alexhroom
Copy link
Collaborator

alexhroom commented Feb 12, 2025

  • bayesResults.dreamOutput.modelOutput is unused - it is set to zero on initialisation and is never changed.
  • problemStruct.otherParams and problemStruct.otherLimits are not necessary
  • For the Priors struct , only priors.priorNames and priors.priorValues are used the remaining properties e.g. priors.bulkIn etc. should be removed. Removes unused fields from priors struct #348

We should consider removing placeholders from users facing code (core calculation should not be touched) to avoid confusing the users since all these things will show up in the documentation API reference. All can be re-added as needed after the release

  • QzShift - this is still present in the problemStruct which affects the Python code
  • problemStruct.oilChiDataPresent, contrastClass.oilChiData and the oilWater projects - this show up in the docs which can be confusing
  • Magnetic and MagneticDomains - these are very easy to add back but should be removed before release to avoid confusion
  • problemStruct.repeatLayers not implemented
@StephenNneji StephenNneji added this to the v1.0 milestone Feb 17, 2025
@StephenNneji StephenNneji changed the title bayesResults.dreamOutput.modelOutput is unused Unused properties in input and output structs Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants