Skip to content

Commit d6a5efa

Browse files
Deepika UpadhyayRakshith-R
Deepika Upadhyay
authored and
Rakshith-R
committed
ci: timeout-minutes has a known issue with composite
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
1 parent 6bd5f6e commit d6a5efa

10 files changed

+31
-10
lines changed

‎.github/workflows/build.yml

+3
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ jobs:
7272
run: tests/scripts/validate_modified_files.sh gen-rbac
7373

7474
- name: consider debugging
75+
if: failure()
76+
timeout-minutes: 60
7577
uses: ./.github/workflows/tmate_debug
7678
with:
7779
use-tmate: ${{ secrets.USE_TMATE }}
@@ -105,6 +107,7 @@ jobs:
105107
106108
- name: consider debugging
107109
if: failure()
110+
timeout-minutes: 60
108111
uses: ./.github/workflows/tmate_debug
109112
with:
110113
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/canary-integration-test.yml

+19
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ jobs:
204204

205205
- name: consider debugging
206206
if: failure() && github.event_name == 'pull_request'
207+
timeout-minutes: 60
207208
uses: ./.github/workflows/tmate_debug
208209
with:
209210
use-tmate: ${{ secrets.USE_TMATE }}
@@ -257,6 +258,7 @@ jobs:
257258

258259
- name: consider debugging
259260
if: failure() && github.event_name == 'pull_request'
261+
timeout-minutes: 60
260262
uses: ./.github/workflows/tmate_debug
261263
with:
262264
use-tmate: ${{ secrets.USE_TMATE }}
@@ -304,6 +306,7 @@ jobs:
304306

305307
- name: consider debugging
306308
if: failure() && github.event_name == 'pull_request'
309+
timeout-minutes: 60
307310
uses: ./.github/workflows/tmate_debug
308311
with:
309312
use-tmate: ${{ secrets.USE_TMATE }}
@@ -357,6 +360,7 @@ jobs:
357360

358361
- name: consider debugging
359362
if: failure() && github.event_name == 'pull_request'
363+
timeout-minutes: 60
360364
uses: ./.github/workflows/tmate_debug
361365
with:
362366
use-tmate: ${{ secrets.USE_TMATE }}
@@ -455,6 +459,7 @@ jobs:
455459

456460
- name: consider debugging
457461
if: failure() && github.event_name == 'pull_request'
462+
timeout-minutes: 60
458463
uses: ./.github/workflows/tmate_debug
459464
with:
460465
use-tmate: ${{ secrets.USE_TMATE }}
@@ -528,6 +533,7 @@ jobs:
528533

529534
- name: consider debugging
530535
if: failure() && github.event_name == 'pull_request'
536+
timeout-minutes: 60
531537
uses: ./.github/workflows/tmate_debug
532538
with:
533539
use-tmate: ${{ secrets.USE_TMATE }}
@@ -577,6 +583,7 @@ jobs:
577583

578584
- name: consider debugging
579585
if: failure() && github.event_name == 'pull_request'
586+
timeout-minutes: 60
580587
uses: ./.github/workflows/tmate_debug
581588
with:
582589
use-tmate: ${{ secrets.USE_TMATE }}
@@ -629,6 +636,7 @@ jobs:
629636

630637
- name: consider debugging
631638
if: failure() && github.event_name == 'pull_request'
639+
timeout-minutes: 60
632640
uses: ./.github/workflows/tmate_debug
633641
with:
634642
use-tmate: ${{ secrets.USE_TMATE }}
@@ -698,6 +706,7 @@ jobs:
698706

699707
- name: consider debugging
700708
if: failure() && github.event_name == 'pull_request'
709+
timeout-minutes: 60
701710
uses: ./.github/workflows/tmate_debug
702711
with:
703712
use-tmate: ${{ secrets.USE_TMATE }}
@@ -749,6 +758,7 @@ jobs:
749758

750759
- name: consider debugging
751760
if: failure() && github.event_name == 'pull_request'
761+
timeout-minutes: 60
752762
uses: ./.github/workflows/tmate_debug
753763
with:
754764
use-tmate: ${{ secrets.USE_TMATE }}
@@ -801,6 +811,7 @@ jobs:
801811

802812
- name: consider debugging
803813
if: failure() && github.event_name == 'pull_request'
814+
timeout-minutes: 60
804815
uses: ./.github/workflows/tmate_debug
805816
with:
806817
use-tmate: ${{ secrets.USE_TMATE }}
@@ -881,6 +892,7 @@ jobs:
881892

882893
- name: consider debugging
883894
if: failure() && github.event_name == 'pull_request'
895+
timeout-minutes: 60
884896
uses: ./.github/workflows/tmate_debug
885897
with:
886898
use-tmate: ${{ secrets.USE_TMATE }}
@@ -943,6 +955,7 @@ jobs:
943955

944956
- name: consider debugging
945957
if: failure() && github.event_name == 'pull_request'
958+
timeout-minutes: 60
946959
uses: ./.github/workflows/tmate_debug
947960
with:
948961
use-tmate: ${{ secrets.USE_TMATE }}
@@ -997,6 +1010,7 @@ jobs:
9971010

9981011
- name: consider debugging
9991012
if: failure() && github.event_name == 'pull_request'
1013+
timeout-minutes: 60
10001014
uses: ./.github/workflows/tmate_debug
10011015
with:
10021016
use-tmate: ${{ secrets.USE_TMATE }}
@@ -1247,6 +1261,7 @@ jobs:
12471261

12481262
- name: consider debugging
12491263
if: failure() && github.event_name == 'pull_request'
1264+
timeout-minutes: 60
12501265
uses: ./.github/workflows/tmate_debug
12511266
with:
12521267
use-tmate: ${{ secrets.USE_TMATE }}
@@ -1275,6 +1290,7 @@ jobs:
12751290

12761291
- name: consider debugging
12771292
if: failure() && github.event_name == 'pull_request'
1293+
timeout-minutes: 60
12781294
uses: ./.github/workflows/tmate_debug
12791295
with:
12801296
use-tmate: ${{ secrets.USE_TMATE }}
@@ -1306,6 +1322,7 @@ jobs:
13061322

13071323
- name: consider debugging
13081324
if: failure() && github.event_name == 'pull_request'
1325+
timeout-minutes: 60
13091326
uses: ./.github/workflows/tmate_debug
13101327
with:
13111328
use-tmate: ${{ secrets.USE_TMATE }}
@@ -1387,6 +1404,7 @@ jobs:
13871404

13881405
- name: consider debugging
13891406
if: failure() && github.event_name == 'pull_request'
1407+
timeout-minutes: 60
13901408
uses: ./.github/workflows/tmate_debug
13911409
with:
13921410
use-tmate: ${{ secrets.USE_TMATE }}
@@ -1439,6 +1457,7 @@ jobs:
14391457

14401458
- name: consider debugging
14411459
if: failure() && github.event_name == 'pull_request'
1460+
timeout-minutes: 60
14421461
uses: ./.github/workflows/tmate_debug
14431462
with:
14441463
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/integration-test-helm-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ jobs:
6363

6464
- name: consider debugging
6565
if: failure() && github.event_name == 'pull_request'
66+
timeout-minutes: 60
6667
uses: ./.github/workflows/tmate_debug
6768
with:
6869
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/integration-test-mgr-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ jobs:
5757

5858
- name: consider debugging
5959
if: failure() && github.event_name == 'pull_request'
60+
timeout-minutes: 60
6061
uses: ./.github/workflows/tmate_debug
6162
with:
6263
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/integration-test-multi-cluster-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ jobs:
5959

6060
- name: consider debugging
6161
if: failure() && github.event_name == 'pull_request'
62+
timeout-minutes: 60
6263
uses: ./.github/workflows/tmate_debug
6364
with:
6465
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/integration-test-object-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ jobs:
5858

5959
- name: consider debugging
6060
if: failure() && github.event_name == 'pull_request'
61+
timeout-minutes: 60
6162
uses: ./.github/workflows/tmate_debug
6263
with:
6364
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/integration-test-smoke-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ jobs:
5858

5959
- name: consider debugging
6060
if: failure() && github.event_name == 'pull_request'
61+
timeout-minutes: 60
6162
uses: ./.github/workflows/tmate_debug
6263
with:
6364
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/integration-test-upgrade-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ jobs:
106106

107107
- name: consider debugging
108108
if: failure() && github.event_name == 'pull_request'
109+
timeout-minutes: 60
109110
uses: ./.github/workflows/tmate_debug
110111
with:
111112
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/push-build.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ jobs:
7878
7979
- name: consider debugging
8080
if: failure()
81+
timeout-minutes: 60
8182
uses: ./.github/workflows/tmate_debug
8283
with:
8384
use-tmate: ${{ secrets.USE_TMATE }}

‎.github/workflows/tmate_debug/action.yml

+2-10
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,18 @@ description: "Setup tmate session if the test fails"
33
inputs:
44
use-tmate:
55
description: "boolean for enabling TMATE"
6-
required: false
7-
timeout-minutes:
8-
description: "timeout tmate debug session"
9-
required: false
10-
default: '60'
11-
# ...name, description and inputs as above
6+
required: true
127
runs:
138
using: "composite"
149
steps:
1510
- name: consider debugging
1611
shell: bash --noprofile --norc -eo pipefail -x {0}
17-
if: failure() && github.event_name == 'pull_request'
1812
run: |
1913
# Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
2014
if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ inputs.use-tmate }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
2115
echo USE_TMATE=1 >> $GITHUB_ENV
2216
fi
23-
echo "${{ inputs.timeout-minutes }}"
2417
2518
- name: set up tmate session for debugging
26-
if: failure() && env.USE_TMATE
19+
if: env.USE_TMATE
2720
uses: mxschmitt/action-tmate@v3
28-
timeout-minutes: "${{ inputs.timeout-minutes }}"

0 commit comments

Comments
 (0)