Support for ScriptableObject Tool parameters

[Bodekaer]

Hi @StephenHodgson,
Do you know if ScriptableObject is supported as a Tool parameter?
I've tested it here and it somehow doesn't seem to include the parameters in the request.

Simple example:

	public class ConfigSo : ScriptableObject
	{
		public string Id => _id;
		[SerializeField] [JsonProperty] [ReadOnly]
		private string _id;
        }

        public async void ToolWithScriptableObject(ConfigSo config) {
                ...
        }

I can always default back to using simple objects, and then just manually create the ScriptableObject afterwards.
But wanted to check with you first :)

[Bodekaer]

REST 400 Error I get:

{
  "error": {
    "message": "Invalid schema for function 'ToolWithScriptableObject': In context=(), 'required' is required to be supplied and to be an array including every key in properties. Missing 'CanRunTasksInParallel'.",
    "type": "invalid_request_error",
    "param": "tools[0].function.parameters",
    "code": "invalid_function_parameters"
  }
}

[Bodekaer]

Yeah I see the challenge.
I think the current setup to not include inherited properties makes sense, and then we could just add a setting/option on to include inherited properties or not. Then it's generic enough as well.

The last example I posted above didn't use UnityObjects though. It's a separate issue I'm trying to debug.
Notice that some properties are not always included in the required list, and it appears to happen if the classes are listed under "definitions".

It seems to work fine if I just list the same object as a variable and not an array (arrays causes it to list it under definitions, where some properties are then excluded from the required list.
Any idea which line to tweak to always include in the required list. I guess all properties should always be added there.

I may just simple create a separate simpler non-Unity-inherited object for the serialization, and then cast/convert them to the Unity ScriptableObject when the GPT assistant returns them.

[StephenHodgson]

Notice that some properties are not always included in the required list, and it appears to happen if the classes are listed under "definitions".

This is because I'm using schema $ref their respective requirements are listed with each class def ref

[StephenHodgson]

I guess all properties should always be added there.

That is correct, so that there would not be a limit to the recursion and serialization depth in the json.

[StephenHodgson]

I may just simple create a separate simpler non-Unity-inherited object for the serialization, and then cast/convert them to the Unity ScriptableObject when the GPT assistant returns them.

Yeah just make your own class that serializes them to the json you prefer (if you wanna use my TypeExtensions class as a template). Then pass the raw json schema in with your request or tool creation. (pretty sure I made it possible to define a tool via json only).

[StephenHodgson]

In the meantime I'll write up some unit tests for the nested example and do my best to sus out the right answers there along with ScriptableObject and UnityEngine types.