Skip to content

Code Review

Chao Liu edited this page Feb 23, 2022 · 4 revisions
  • For a review comment, only the original reviewer can "resolve" it.
  • If a PR is merged before all comments are resolved
    • A post-merge issue need to be created to track that PR and all unaddressed comments.
  • Add prefix WIP: in the title if a PR is created but not ready for review and merge. Also the CI system could make use of this.