-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To Do List #70
Comments
For this one, I think the answer is: don't use |
Interesting design.... the author uses the package startup message as a sort of dedication page.. The solution is |
mmmm dont think it did though - only put the axis labels every couple of weeks, or will it automatically add them all but just making them go slanted? |
By default, it will only put labels at six points along the curve. That can be changed by setting |
I'm not exactly sure what this means... Does this mean that you want the epicurve on a bi-weekly basis or that you want to track data on a bi-weekly basis? |
We've seen that referencing lines doesn't really work too well. Referencing chunks by name is the best way to go so far. |
I believe the plan is to add a stratifying option to the proportion functions so that a lot of the boilerplate can go away. |
This is more than one point!
Alex: haha horizontal lines I think you fixed already and i didnt update this |
you add a line on top of the bars for epicurves, for each week you take the x number of weeks before and x number of weeks after to calculate the average. Essentially just smooths out the epicurve - useful for when your surveillance/reporting coverage fluctuates by week. Can do it with rollapply in zoo package - but wonder if worth adding as an option to incidence package? Zhian: I think this is a reasonable request for the epicurve. It seems similar to the goals of reconhub/incidence#75 and reconhub/incidence#83 Alex: mmm simpler than those requests. In most cases, for each week - you take the counts from x number of weeks before, average those counts and plot for that week. See ecdc report essentially it would be: Zhian: Yup, but the I would need to write a general function that would annotate the epicurve, which would also fit those purposes. |
you or me? Zhian: I could give it a stab |
I think this and getting rid of |
Everywhere:
[Zhian] text size in plots doesnt respond to theme_set base_size from setup chunk; only when setting element_text in the plot itself. Need to adapt outbreak and survey templates accordingly.
[Discussion] would be good to also output a document (beside the word) which summarises what datasets were used (and their file paths), starting cases, dropped cases where the output is. And maybe warnings/errors?[moved to nice-to-haves pr][Zhian] in tab_* functions, change the warning when dropping NAs to be "call. = FALSE" to the warning function - as descriptive is no longer a user-facing function.
[Zhian] add a license to the repo? see Question: who is the copyright holder? #44
[Kate/Neale / Alex / Zhian] decide if also want to show code for making implicit NAs out of explicit e.g. "Missing" chars to NA. So if you want to make "No answer" an implicit NA, you would use fct_recode(NULL = "No answer")
[Kate] update all sitrep::descriptive tables with groupers to use sitrep::rename_redundant and augment_redundant for renaming similar columns
[Neale] Add chi-squared test and t.test examples to website (there is already an example of this in the vaccination survey)[moved to https://github.com/Show example code comparing HEV rdt positives v negatives R4EPIs-website#19#issue-494502584 on website][Zhian/Alex] consider dropping sitrep::discreptive in favour of arsenal::tableby (dplyr compatible? simple enough syntax for beginners?) - decided against, syntax too dense
[Neale] Under "## Installing and loading required packages " add that can check where your packages are using .libPaths() and give link to wiki/training material. Currently only says: "Program Files/R/R-[version]/library" which wont always be the case (particularly on MSF computers).
[Neale?] double check that case_when is doing what it should when NAs are involved. case_when doesnt leave NAs as NAs, need to add extra argument. see below:
Surveys:
Extras:
[NICE TO HAVE] if have time then add in the options to add sample size calculations see Support sample size calculations for all three surveys #5[moved to nice to have pr][NICE TO HAVE] on all plots - make y axis numbering go to top of axis, this happens because of expand(c(0,0)[moved to nice to have pr][see: https://github.com/Add option to calculate/plot rolling averages reconhub/incidence#105] on epicurves - possible to add a 2 weekly moving average? - issue posted on recon. Long term issue case.[moved to nice to have pr]https://timogrossenbacher.ch/2019/04/bivariate-maps-with-ggplot2-and-sf/ Mense, just stick with what we have.
Outbreaks:
From measles:
#### Demographics
The text was updated successfully, but these errors were encountered: