Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip settings not working for file listed on the command line when --resolve-all-configs is used #2335

Open
SpecLad opened this issue Jan 16, 2025 · 0 comments

Comments

@SpecLad
Copy link

SpecLad commented Jan 16, 2025

Create pyproject.toml:

[tool.isort]
extend_skip=['a.py']

Create an empty a.py.

Now compare:

$ isort -v a.py

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.13.2

$ isort -v --resolve-all-configs a.py

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.13.2

./pyproject.toml used for file a.py

--resolve-all-configs shouldn't have an effect on which files are ignored, so one of these commands is doing the wrong thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant