-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biome blending for tints #197
Comments
A pre-requist for this would be to get the block accurate biome in mineflayer. Since 1.15 the server only send biomes values for squares of 4x4 blocks, the client has to interpolate to get the individual block biomes. prismarine-rng implement the VoronoiLayer code that does this interpolation https://github.com/PrismarineJS/prismarine-rng/blob/master/lib/biomes/layers.js#L561 but it needs to be integrated into mineflayer (and it should be computed on demand as it is not a trivial computation and biomes are rarely needed). Once each block has a correct biome value, blending two tints is very straightforward, we just have to put a different tint on each vertex of the cube instead of the same on every vertices. |
I think we’ll still have to compute the blend a bit before putting the
different colours on the vertices because the blending radius is usually
larger than one block, right?
…On Wed, Jun 23, 2021 at 14:35, Karang ***@***.***> wrote:
A pre-requist for this would be to get the block accurate biome in
mineflayer. Since 1.15 the server only send biomes values for squares of
4x4 blocks, the client has to interpolate to get the individual block
biomes. prismarine-rng implement the VoronoiLayer code that does this
interpolation
https://github.com/PrismarineJS/prismarine-rng/blob/master/lib/biomes/layers.js#L561
but it needs to be integrated into mineflayer (and it should be computed on
demand as it is not a trivial computation and biomes are rarely needed).
Once each block has a correct biome value, blending two tints is very
straightforward, we just have to put a different tint on each vertex of the
cube instead of the same on every vertices.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#197 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMVK4MQGBVZW43CGRJ4YG4LTUISNXANCNFSM47GIW2TQ>
.
|
Yes this part of the computation of the tint we put on each vertex. |
As of #25, we added biome tints. However, Vanilla has "biome blending," where the tints of blocks on the edges of biomes are blurred together to make the change between biomes more gradual/subtle. We do not; and this looks especially silly with trees (screenshot below).
This looks silly.
To reproduce
The text was updated successfully, but these errors were encountered: