chore: cleanup unused namespaces - enable implicit usings

Author: dansiegel

.editorconfig

@@ -153,7 +153,7 @@ csharp_indent_labels = one_less_than_current
 csharp_using_directive_placement = outside_namespace:silent
 csharp_prefer_simple_using_statement = true:suggestion
 csharp_prefer_braces = true:silent
-csharp_style_namespace_declarations = file_scoped:warning
+csharp_style_namespace_declarations = file_scoped:silent
 csharp_style_prefer_method_group_conversion = true:silent
 csharp_style_prefer_top_level_statements = true:silent
 csharp_style_prefer_primary_constructors = true:suggestion

Directory.Build.props

@@ -23,6 +23,8 @@
       System.Diagnostics.CodeAnalysis.MaybeNullWhenAttribute;
       System.Runtime.CompilerServices.IsExternalInit;
     </PolySharpIncludeGeneratedTypes>
+    <WarningsAsErrors>$(WarningsAsErrors);IDE0003</WarningsAsErrors>
+    <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
   <PropertyGroup>

src/Directory.Build.props

@@ -8,6 +8,7 @@
     <IsPackable Condition=" '$(IsFormsProject)' ">!$(DisableFormsPublish)</IsPackable>
     <IsPackable Condition=" '$(IsUnoProject)' ">!$(DisableUnoPublish)</IsPackable>
     <ContinuousIntegrationBuild Condition="'$(BUILD_BUILDID)' != ''">true</ContinuousIntegrationBuild>
+    <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
   <Choose>

src/Maui/Prism.Maui.Rx/GlobalNavigationObserver.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Reactive.Subjects;
 using Prism.Events;
 

src/Maui/Prism.Maui.Rx/IGlobalNavigationObserver.cs

@@ -1,7 +1,6 @@
-using System;
-
 namespace Prism.Navigation;
 
+
 public interface IGlobalNavigationObserver
 {
     IObservable<NavigationRequestContext> NavigationRequest { get; }

src/Maui/Prism.Maui.Rx/NavigationObserverRegistrationExtensions.cs

@@ -1,5 +1,3 @@
-using Prism.Ioc;
-
 namespace Prism.Navigation;
 
 public static class NavigationObserverRegistrationExtensions
@@ -29,4 +27,4 @@ public static PrismAppBuilder AddGlobalNavigationObserver(this PrismAppBuilder b
         {
             addObservable(c, c.Resolve<IGlobalNavigationObserver>().NavigationRequest);
         });
-}
+}

src/Maui/Prism.Maui/PrismAppBuilderExtensions.cs

@@ -1,4 +1,4 @@
-using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging;
 using Prism.Modularity;
 using Prism.Mvvm;
 using Prism.Navigation;

src/Uno/Prism.Uno/Interactivity/InvokeCommandAction.cs

@@ -1,10 +1,6 @@
-using System;
-using System.Collections.Generic;
 using System.Reflection;
-using System.Text;
 using System.Windows.Input;
 using Microsoft.Xaml.Interactivity;
-using Microsoft.UI.Xaml;
 
 
 namespace Prism.Interactivity

src/Uno/Prism.Uno/Mvvm/ViewModelLocator.cs

@@ -1,5 +1,3 @@
-using Microsoft.UI.Xaml;
-
 namespace Prism.Mvvm
 {
     /// <summary>

src/Uno/Prism.Uno/Navigation/Regions/NavigationViewRegionAdapter.cs

@@ -1,6 +1,3 @@
-using Microsoft.UI.Xaml;
-using Microsoft.UI.Xaml.Controls;
-
 namespace Prism.Navigation.Regions;
 
 public sealed class NavigationViewRegionAdapter : RegionAdapterBase<NavigationView>

src/Uno/Prism.Uno/PrismApplicationBase.cs

@@ -1,6 +1,5 @@
-using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
-using Microsoft.UI.Xaml;
 using Prism.Common;
 using Prism.Modularity;
 using Prism.Mvvm;

src/Wpf/Prism.DryIoc.Wpf/PrismApplication.cs

@@ -1,7 +1,4 @@
-using System;
 using DryIoc;
-using Prism.Container.DryIoc;
-using Prism.Ioc;
 using ExceptionExtensions = System.ExceptionExtensions;
 
 namespace Prism.DryIoc

src/Wpf/Prism.DryIoc.Wpf/PrismBootstrapper.cs

@@ -1,7 +1,4 @@
-using System;
 using DryIoc;
-using Prism.Container.DryIoc;
-using Prism.Ioc;
 
 namespace Prism.DryIoc
 {

src/Wpf/Prism.Unity.Wpf/PrismApplication.cs

@@ -1,6 +1,3 @@
-using System;
-using Prism.Container.Unity;
-using Prism.Ioc;
 using Unity;
 
 namespace Prism.Unity

src/Wpf/Prism.Unity.Wpf/PrismBootstrapper.cs

@@ -1,6 +1,3 @@
-using System;
-using Prism.Container.Unity;
-using Prism.Ioc;
 using Unity;
 
 namespace Prism.Unity

src/Wpf/Prism.Wpf/Common/MvvmHelpers.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
 using System.ComponentModel;
-using System.Linq;
 using Prism.Mvvm;
 
 namespace Prism.Common

src/Wpf/Prism.Wpf/Dialogs/DialogService.cs

@@ -1,9 +1,5 @@
-using System;
 using System.ComponentModel;
-using System.Linq;
-using System.Windows;
 using Prism.Common;
-using Prism.Ioc;
 
 namespace Prism.Dialogs
 {

src/Wpf/Prism.Wpf/Dialogs/DialogWindow.xaml.cs

@@ -1,5 +1,3 @@
-using System.Windows;
-
 namespace Prism.Dialogs
 {
     /// <summary>

src/Wpf/Prism.Wpf/Dialogs/IDialogServiceCompatExtensions.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace Prism.Dialogs
 {
     /// <summary>

src/Wpf/Prism.Wpf/Dialogs/IDialogWindow.cs

@@ -1,6 +1,4 @@
-using System;
 using System.ComponentModel;
-using System.Windows;
 
 namespace Prism.Dialogs
 {

src/Wpf/Prism.Wpf/Extensions/CollectionExtensions.cs

@@ -1,7 +1,3 @@
-
-
-using System.Collections.Generic;
-
 namespace System.Collections.ObjectModel
 {
     /// <summary>

src/Wpf/Prism.Wpf/Extensions/DependencyObjectExtensions.cs

@@ -1,7 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-
 namespace Prism
 {
     internal static partial class DependencyObjectExtensions

src/Wpf/Prism.Wpf/Interactivity/CommandBehaviorBase.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Windows.Input;
 
 namespace Prism.Interactivity

src/Wpf/Prism.Wpf/Interactivity/InvokeCommandAction.cs

@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Windows;
 using System.Windows.Input;
 using Microsoft.Xaml.Behaviors;
 

src/Wpf/Prism.Wpf/Ioc/ContainerProviderExtension.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Windows.Markup;
 
 namespace Prism.Ioc

src/Wpf/Prism.Wpf/Ioc/IContainerRegistryExtensions.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Diagnostics.CodeAnalysis;
 using Prism.Mvvm;
 

src/Wpf/Prism.Wpf/Modularity/AssemblyResolver.Desktop.cs

@@ -1,9 +1,4 @@
-
-
-using System;
-using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Reflection;
 using Prism.Properties;
 
@@ -17,7 +12,7 @@ public class AssemblyResolver : IAssemblyResolver, IDisposable
     {
         private readonly List<AssemblyInfo> registeredAssemblies = new List<AssemblyInfo>();
 
-        private bool handlesAssemblyResolve;
+        private bool _handlesAssemblyResolve;
 
         /// <summary>
         /// Registers the specified assembly and resolves the types in it when the AppDomain requests for it.
@@ -27,10 +22,10 @@ public class AssemblyResolver : IAssemblyResolver, IDisposable
         /// declared in the assembly.</remarks>
         public void LoadAssemblyFrom(string assemblyFilePath)
         {
-            if (!this.handlesAssemblyResolve)
+            if (!_handlesAssemblyResolve)
             {
-                AppDomain.CurrentDomain.AssemblyResolve += this.CurrentDomain_AssemblyResolve;
-                this.handlesAssemblyResolve = true;
+                AppDomain.CurrentDomain.AssemblyResolve += CurrentDomain_AssemblyResolve;
+                _handlesAssemblyResolve = true;
             }
 
             Uri assemblyUri = GetFileUri(assemblyFilePath);
@@ -46,15 +41,15 @@ public void LoadAssemblyFrom(string assemblyFilePath)
             }
 
             AssemblyName assemblyName = AssemblyName.GetAssemblyName(assemblyUri.LocalPath);
-            AssemblyInfo assemblyInfo = this.registeredAssemblies.FirstOrDefault(a => assemblyName == a.AssemblyName);
+            AssemblyInfo assemblyInfo = registeredAssemblies.FirstOrDefault(a => assemblyName == a.AssemblyName);
 
             if (assemblyInfo != null)
             {
                 return;
             }
 
             assemblyInfo = new AssemblyInfo() { AssemblyName = assemblyName, AssemblyUri = assemblyUri };
-            this.registeredAssemblies.Add(assemblyInfo);
+            registeredAssemblies.Add(assemblyInfo);
         }
 
         private static Uri GetFileUri(string filePath)
@@ -83,7 +78,7 @@ private Assembly CurrentDomain_AssemblyResolve(object sender, ResolveEventArgs a
         {
             AssemblyName assemblyName = new AssemblyName(args.Name);
 
-            AssemblyInfo assemblyInfo = this.registeredAssemblies.FirstOrDefault(a => AssemblyName.ReferenceMatchesDefinition(assemblyName, a.AssemblyName));
+            AssemblyInfo assemblyInfo = registeredAssemblies.FirstOrDefault(a => AssemblyName.ReferenceMatchesDefinition(assemblyName, a.AssemblyName));
 
             if (assemblyInfo != null)
             {
@@ -116,7 +111,7 @@ private class AssemblyInfo
         /// <filterpriority>2</filterpriority>
         public void Dispose()
         {
-            this.Dispose(true);
+            Dispose(true);
             GC.SuppressFinalize(this);
         }
 
@@ -126,10 +121,10 @@ public void Dispose()
         /// <param name="disposing">When <see langword="true"/>, it is being called from the Dispose method.</param>
         protected virtual void Dispose(bool disposing)
         {
-            if (this.handlesAssemblyResolve)
+            if (_handlesAssemblyResolve)
             {
-                AppDomain.CurrentDomain.AssemblyResolve -= this.CurrentDomain_AssemblyResolve;
-                this.handlesAssemblyResolve = false;
+                AppDomain.CurrentDomain.AssemblyResolve -= CurrentDomain_AssemblyResolve;
+                _handlesAssemblyResolve = false;
             }
         }
 

src/Wpf/Prism.Wpf/Modularity/ConfigurationModuleCatalog.Desktop.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
 using System.Collections.ObjectModel;
-using System.Linq;
 using Prism.Properties;
 
 namespace Prism.Modularity

src/Wpf/Prism.Wpf/Modularity/ConfigurationStore.Desktop.cs

@@ -1,5 +1,3 @@
-
-
 using System.Configuration;
 
 namespace Prism.Modularity

src/Wpf/Prism.Wpf/Modularity/DirectoryModuleCatalog.net45.cs

@@ -1,9 +1,6 @@
-using System;
-using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Globalization;
 using System.IO;
-using System.Linq;
 using System.Reflection;
 using System.Security.Policy;
 using Prism.Properties;
@@ -33,14 +30,14 @@ public class DirectoryModuleCatalog : ModuleCatalog
         /// </summary>
         protected override void InnerLoad()
         {
-            if (string.IsNullOrEmpty(this.ModulePath))
+            if (string.IsNullOrEmpty(ModulePath))
                 throw new InvalidOperationException(Resources.ModulePathCannotBeNullOrEmpty);
 
-            if (!Directory.Exists(this.ModulePath))
+            if (!Directory.Exists(ModulePath))
                 throw new InvalidOperationException(
-                    string.Format(CultureInfo.CurrentCulture, Resources.DirectoryNotFound, this.ModulePath));
+                    string.Format(CultureInfo.CurrentCulture, Resources.DirectoryNotFound, ModulePath));
 
-            AppDomain childDomain = this.BuildChildDomain(AppDomain.CurrentDomain);
+            AppDomain childDomain = BuildChildDomain(AppDomain.CurrentDomain);
 
             try
             {
@@ -66,7 +63,7 @@ select assembly.Location
                         (InnerModuleInfoLoader)
                         childDomain.CreateInstanceFrom(loaderType.Assembly.Location, loaderType.FullName).Unwrap();
                     loader.LoadAssemblies(loadedAssemblies);
-                    this.Items.AddRange(loader.GetModuleInfos(this.ModulePath));
+                    Items.AddRange(loader.GetModuleInfos(ModulePath));
                 }
             }
             finally

src/Wpf/Prism.Wpf/Modularity/DirectoryModuleCatalog.netcore.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Globalization;
@@ -32,12 +32,12 @@ public class DirectoryModuleCatalog : ModuleCatalog
         /// </summary>
         protected override void InnerLoad()
         {
-            if (string.IsNullOrEmpty(this.ModulePath))
+            if (string.IsNullOrEmpty(ModulePath))
                 throw new InvalidOperationException(Resources.ModulePathCannotBeNullOrEmpty);
 
-            if (!Directory.Exists(this.ModulePath))
+            if (!Directory.Exists(ModulePath))
                 throw new InvalidOperationException(
-                    string.Format(CultureInfo.CurrentCulture, Resources.DirectoryNotFound, this.ModulePath));
+                    string.Format(CultureInfo.CurrentCulture, Resources.DirectoryNotFound, ModulePath));
 
             AppDomain childDomain = AppDomain.CurrentDomain;
 
@@ -63,7 +63,7 @@ select assembly.Location
                         (InnerModuleInfoLoader)
                         childDomain.CreateInstanceFrom(loaderType.Assembly.Location, loaderType.FullName).Unwrap();
 
-                    this.Items.AddRange(loader.GetModuleInfos(this.ModulePath));
+                    Items.AddRange(loader.GetModuleInfos(ModulePath));
                 }
             }
             catch (Exception ex)