feedback

Author: anmenaga

README.md

@@ -127,10 +127,10 @@ _NOTE: If you'd rather not use the script, simply copy the `out/Microsoft.PowerS
 
 #### Running
 
-First, you must run pwsh with sudo:
+Start PowerShell:
 
 ```powershell
-sudo pwsh
+pwsh
 ```
 
 If you have the `Microsoft.PowerShell.IoT` module in your PSModulePath:

src/Microsoft.PowerShell.IoT/Gpio/Get/GetGpioPin.cs

@@ -6,7 +6,7 @@
 [Cmdlet(VerbsCommon.Get, "GpioPin")]
 public class GetGpioPin : GpioCmdletBase
 {
-    [Parameter(Mandatory = false, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true, Position = 0)]
+    [Parameter(Mandatory = true, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true, Position = 0)]
     public int[] Id { get; set; }
 
     [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, Position = 1)]
@@ -22,6 +22,7 @@ protected override void ProcessRecord()
         if ((this.Id == null) || (this.Id.Length <= 0))
         {
             // TODO: this is "gpio readall" functionality
+            // do not forget to change Id param to Mandatory = false when this is implemented
         }
         else
         {
@@ -43,17 +44,7 @@ protected override void ProcessRecord()
         {
             SignalLevel slResult = SignalLevel.Low;
 
-             if (this.GpioController.IsPinOpen(pinId))
-            {
-                if (this.GpioController.GetPinMode(pinId) != mode)
-                {
-                    this.GpioController.SetPinMode(pinId, mode);
-                }
-            }
-            else
-            {
-                this.GpioController.OpenPin(pinId, mode);
-            }
+            this.EnsureOpenPin(pinId, mode);
 
             if (this.GpioController.Read(pinId) == PinValue.High)
             {
@@ -78,4 +69,4 @@ public enum PullMode
     Off = 0,
     PullDown = 1,
     PullUp = 2
-}
+}

src/Microsoft.PowerShell.IoT/Gpio/GpioCmdletBase.cs

@@ -20,6 +20,21 @@ protected GpioController GpioController
             StaticGpioController = value;
         }
     }
+
+    protected void EnsureOpenPin(int pinId, PinMode mode)
+    {
+        if (this.GpioController.IsPinOpen(pinId))
+        {
+            if (this.GpioController.GetPinMode(pinId) != mode)
+            {
+                this.GpioController.SetPinMode(pinId, mode);
+            }
+        }
+        else
+        {
+            this.GpioController.OpenPin(pinId, mode);
+        }
+    }
 }
 
 [Cmdlet(VerbsCommon.Clear, "GpioResources")]
@@ -33,4 +48,4 @@ protected override void ProcessRecord()
             GpioCmdletBase.StaticGpioController = null;
         }
     }
-}
+}

src/Microsoft.PowerShell.IoT/Gpio/GpioPinData.cs

@@ -14,4 +14,4 @@ public enum SignalLevel
 {
     Low = 0,
     High = 1
-}
+}

src/Microsoft.PowerShell.IoT/Gpio/Set/SetGpioPin.cs

@@ -20,17 +20,7 @@ protected override void ProcessRecord()
         {
             foreach (int pinId in this.Id)
             {
-                if (this.GpioController.IsPinOpen(pinId))
-                {
-                    if (this.GpioController.GetPinMode(pinId) != PinMode.Output)
-                    {
-                        this.GpioController.SetPinMode(pinId, PinMode.Output);
-                    }
-                }
-                else
-                {
-                    this.GpioController.OpenPin(pinId, PinMode.Output);
-                }
+                this.EnsureOpenPin(pinId, PinMode.Output);
 
                 if(this.Value == SignalLevel.Low)
                 {
@@ -49,4 +39,4 @@ protected override void ProcessRecord()
             }
         }
     }
-}
+}

src/Microsoft.PowerShell.IoT/I2c/Get/GetI2cDevice.cs

@@ -17,7 +17,6 @@ public class GetI2CDevice : Cmdlet
     public GetI2CDevice()
     {
         this.FriendlyName = string.Empty;
-        this.Id = 0;
         this.BusId = 1;
     }
 
@@ -27,4 +26,4 @@ protected override void ProcessRecord()
         I2cDevice device = I2cDevice.Create(settings);
         WriteObject(new I2CDevice(device, this.Id, this.FriendlyName, this.BusId));
     }
-}
+}

src/Microsoft.PowerShell.IoT/I2c/Get/GetI2cRegister.cs

@@ -59,4 +59,4 @@ protected override void ProcessRecord()
             }
         }
     }
-}
+}

src/Microsoft.PowerShell.IoT/I2c/I2cDevice.cs

@@ -25,4 +25,4 @@ public override string ToString()
             return this.FriendlyName;
         }
     }
-}
+}

src/Microsoft.PowerShell.IoT/I2c/I2cRegisterData.cs

@@ -20,4 +20,4 @@ public I2CDeviceRegisterData()
         : this(null, 0)
     {
     }
-}
+}

src/Microsoft.PowerShell.IoT/I2c/Set/SetI2cRegister.cs

@@ -26,4 +26,4 @@ protected override void ProcessRecord()
             WriteObject(result);
         }
     }
-}
+}

src/Microsoft.PowerShell.IoT/Microsoft.PowerShell.IoT.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Version>0.2.0.0</Version>
     <Authors>Microsoft Corporation</Authors>
     <Company>Microsoft Corporation</Company>
@@ -17,7 +17,7 @@
 
   <ItemGroup>
     <PackageReference Include="System.Device.Gpio" Version="1.0.0" />
-    <PackageReference Include="System.Management.Automation" Version="7.0.0" />
+    <PackageReference Include="PowerShellStandard.Library" Version="7.0.0-preview.1" />
   </ItemGroup>
 
 </Project>

src/Microsoft.PowerShell.IoT/SPI/SPIData.cs

@@ -14,4 +14,4 @@ public SPIData(int busId, int chipSelectLine, int frequency, byte[] data, byte[]
         this.Data = data;
         this.Response = response;
     }
-}
+}

src/Microsoft.PowerShell.IoT/SPI/Send/SendSPIData.cs

@@ -49,4 +49,4 @@ protected override void ProcessRecord()
             }
         }
     }
-}
+}