Fixed bug where we checked for true/false for slider settings, but WooCommerce stores it as 'yes'/'no'

Author: Paulsky

admin/class-wdevs-gallery-slider-admin.php

@@ -73,21 +73,21 @@ public function get_settings() {
 				'type'    => 'checkbox',
 				'desc'    => __( 'Enable scrollbar for the slider', 'wdevs-gallery-slider' ),
 				'id'      => 'wdevs_gallery_slider_scrollbar',
-				'default' => '1'
+				'default' => 'yes'
 			),
 			array(
 				'name'    => __( 'Enable pagination', 'wdevs-gallery-slider' ),
 				'type'    => 'checkbox',
 				'desc'    => __( 'Enable pagination for the slider', 'wdevs-gallery-slider' ),
 				'id'      => 'wdevs_gallery_slider_pagination',
-				'default' => '0'
+				'default' => 'no'
 			),
 			array(
 				'name'    => __( 'Enable navigation', 'wdevs-gallery-slider' ),
 				'type'    => 'checkbox',
 				'desc'    => __( 'Enable navigation for the slider', 'wdevs-gallery-slider' ),
 				'id'      => 'wdevs_gallery_slider_navigation',
-				'default' => '0'
+				'default' => 'no'
 			),
 			array(
 				'name'    => __( 'Disable slider from', 'wdevs-gallery-slider' ),

includes/class-wdevs-gallery-slider-activator.php

@@ -32,7 +32,7 @@ class Wdevs_Gallery_Slider_Activator {
 	public static function activate() {
 		if ( ! is_plugin_active( 'woocommerce/woocommerce.php' ) ) {
 			deactivate_plugins( plugin_basename( __FILE__ ) );
-			
+
 			wp_die( esc_html__( 'This plugin requires WooCommerce. Please install and activate WooCommerce before activating this plugin.', 'wdevs-gallery-slider' ) );
 		}
 
@@ -65,7 +65,14 @@ private static function migrate_settings() {
 		// Update each setting individually
 		foreach ( $settings_mapping as $old_key => $new_key ) {
 			if ( isset( $old_settings[ $old_key ] ) ) {
-				update_option( $new_key, $old_settings[ $old_key ] );
+				if ( $old_key !== 'woo_swiper_breakpoint' ) {
+					// Convert checkbox values to WooCommerce format, which is 'yes'/'no'
+					$new_value = $old_settings[ $old_key ] == '1' ? 'yes' : 'no';
+				} else {
+					// For non-checkbox settings, just use the old value
+					$new_value = $old_settings[ $old_key ];
+				}
+				update_option( $new_key, $new_value );
 			}
 		}
 

public/class-wdevs-gallery-slider-public.php

@@ -93,9 +93,9 @@ public function enqueue_scripts() {
 
 		$localized_settings = [
 			'swiper' => [
-				'scrollbar'  => ! empty( get_option('wdevs_gallery_slider_scrollbar') ),
-				'pagination' => ! empty( get_option('wdevs_gallery_slider_pagination') ),
-				'navigation' => ! empty( get_option('wdevs_gallery_slider_navigation') ),
+				'scrollbar'  => get_option( 'wdevs_gallery_slider_scrollbar', 'yes' ) === 'yes',
+				'pagination' => get_option( 'wdevs_gallery_slider_pagination', 'no' ) === 'yes',
+				'navigation' => get_option( 'wdevs_gallery_slider_navigation', 'no' ) === 'yes',
 				'breakpoint' => $this->parse_breakpoint( get_option( 'wdevs_gallery_slider_breakpoint', '' ) ),
 			]
 		];