fix tests by accounting for NONE access change

Author: Machine-Maker

src/main/java/io/papermc/restamp/at/ModifierTransformationProgress.java

@@ -182,7 +182,7 @@ public void recordFoundVisibilitySpot() {
      */
     @NotNull
     public Result finaliseProgress(
-        @NotNull final Supplier<J.Modifier> visibilityModifierCreator,
+        @Nullable final Supplier<J.Modifier> visibilityModifierCreator,
         @NotNull Space parentSpace
     ) {
         // If we neither found the visibility nor found ones to remove, pretend we found a valid spot at index 0.
@@ -206,7 +206,7 @@ public Result finaliseProgress(
         }
 
         // Insert if the spot is still useful, the visibility was not found.
-        if (this.validVisibilitySpot.useful) {
+        if (this.validVisibilitySpot.useful && visibilityModifierCreator != null) {
             this.modifiers.add(this.validVisibilitySpot.index, visibilityModifierCreator.get());
             this.mutatedFromOriginal = true;
         }

src/main/java/io/papermc/restamp/at/ModifierTransformer.java

@@ -78,6 +78,9 @@ public ModifierTransformationResult transformModifiers(@NotNull final AccessTran
                 continue;
             }
 
+            // Do not touch access modifiers if no change was requested.
+            if (accessTransform.getAccess() == AccessChange.NONE) continue;
+
             // Drop unwanted visibility modifiers and record potential position for new modifier.
             if (modifier.getType() != accessTypeToKeep) {
                 transformationProgress.dropModifier(modifier);
@@ -90,8 +93,9 @@ public ModifierTransformationResult transformModifiers(@NotNull final AccessTran
         }
 
         // Finalise the progress tracker
+        // Only pass a modifier creator if we are requesting access change in the first place
         final ModifierTransformationProgress.Result result = transformationProgress.finaliseProgress(
-            () -> new J.Modifier(
+            accessTransform.getAccess() == AccessChange.NONE ? null : () -> new J.Modifier(
                 Tree.randomId(), Space.EMPTY, Markers.EMPTY, null,
                 Objects.requireNonNull(accessTypeToKeep, "package private caused insertion"), Collections.emptyList()
             ),