Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VehicleDestroyEvent fire aspect issue #11980

Open
JHarris12345 opened this issue Jan 16, 2025 · 1 comment
Open

VehicleDestroyEvent fire aspect issue #11980

JHarris12345 opened this issue Jan 16, 2025 · 1 comment
Labels

Comments

@JHarris12345
Copy link

Expected behavior

A player destroying a boat with a fire aspect weapon should still show the attacker as the player

Observed/Actual behavior

If you destroy a boat with a fire aspect weapon, the e.getAttacker() in the VehicleDestroyEvent is null. This makes it impossible to get the player from this event if they use fire aspect

Steps/models to reproduce

  1. Destroy boat with fire aspect weapon
  2. See how the e.getAttacker() is null

Plugin and Datapack List

N/A

Paper version

This server is running Paper version 1.21.1-132-ver/1.21.1@b48403b (2024-11-21T10:14:27Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.1-DEV-164e116 (MC: 1.21.1)

Other

No response

@Doc94
Copy link
Contributor

Doc94 commented Jan 16, 2025

Fire Aspect call a ignite effect for well apply the fire.. this call EntityCombustEvent/EntityCombustByEntityEvent where the author is send (for the ByEntity) later when damage the entity the "damager" its not passed then when comes to the place where VehicleDestroyEvent is called the damager its not the player....
i dont find a nice way to make the call of damage for fire also know the damager... (or can add a extra field in entity for save the damager in this case and clear when the fire is clear... but still not clean)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants