Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GET /search?type=trip - 部分所需資料缺失 #52

Open
sh1un opened this issue Oct 21, 2023 · 0 comments
Open

[Bug] GET /search?type=trip - 部分所需資料缺失 #52

sh1un opened this issue Oct 21, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sh1un
Copy link
Member

sh1un commented Oct 21, 2023

Bug Report

Deadline: 2023/10/24 23:59 (GMT+8)

Description (2023/10/23 edited)

在使用全文檢索 - 旅途的功能時,Trip 應回傳旅遊者頭貼、旅遊者名稱、評價

  • [ img1 Figma(連結) ]
    image

  • [ img2 Actual Display ]
    image

// Actual Response
{
    "total": 60,
    "startIndex": 0,
    "size": 10,
    "data": [
        {
            "tripId": "b5ae9360c2a44158940156ff864cbe09",
            "shopperId": "07b25dedb9014293987cd967ab394308",
            "fromCountry": "DE",
            "fromCountryChineseName": "德國",
            "fromCity": "TXL",
            "fromCityChineseName": "柏林",
            "toCountry": "TW",
            "toCountryChineseName": "台灣",
            "toCityChineseName": "新北市",
            "toCity": "TPH",
            "arrivalDate": "2023-10-02T00:00:00.000+00:00",
            "profit": 0,
            "currency": "TWD",
            "createDate": "2023-10-02T11:09:37.000+00:00",
            "updateDate": "2023-10-02T11:09:37.000+00:00",
            "tripStatus": "PAST",
            "hasNewActivity": false,
            "dashboard": {
                "requested": 0,
                "toBePurchased": 0,
                "toBeDelivered": 0
            }
        },
        
 // .... 略 ....

Suggested Soulutions

  1. 需要與前端溝通回傳的格式,並確保 Mockup 上面所需的資訊沒有漏傳給前端
  2. 關於欄位命名,其他 API Response 的命名供你參考:
    • 大頭照的名稱: avatarUrl
    • 名字: fullName
    • 評價: averageRating, totalReview, reviewType
      image
      image

APIs

Additional context

Add any other context or screenshots about the feature request here.

@sh1un sh1un added the bug Something isn't working label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants