Merge pull request #202 from PSPDFKit/github-templates

radazzouz · web-flow · commit be86e312cf12 · 2019-04-02T09:55:54.000-04:00
Add Github issue and pull request templates
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -0,0 +1,5 @@
+# Details
+
+
+# Acceptance Criteria
+
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,7 @@
+# Details
+
+
+# Acceptance Criteria
+
+- [ ] When approved, right before merging, rebase with master and increment the package version in `package.json`, `package-lock.json`, and `samples/Catalog/package.json` (see example commit:  https://github.com/PSPDFKit/react-native/pull/202/commits/1bf805feef2ac268743e4905d94d6d8c8f16ec59).
+- [ ] Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-pspdfkit",
-  "version": "1.23.3",
+  "version": "1.23.4",
   "description": "A React Native module for the PSPDFKit library.",
   "keywords": [
     "react native",
diff --git a/samples/Catalog/package.json b/samples/Catalog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "Catalog",
-  "version": "1.23.3",
+  "version": "1.23.4",
   "private": true,
   "scripts": {
     "start": "node node_modules/react-native/local-cli/cli.js start"

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "react-native-pspdfkit",`
`3`		`- "version": "1.23.3",`
	`3`	`+ "version": "1.23.4",`
`4`	`4`	`"description": "A React Native module for the PSPDFKit library.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react native",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "Catalog",`
`3`		`- "version": "1.23.3",`
	`3`	`+ "version": "1.23.4",`
`4`	`4`	`"private": true,`
`5`	`5`	`"scripts": {`
`6`	`6`	`"start": "node node_modules/react-native/local-cli/cli.js start"`