Skip to content

Commit d9e4f00

Browse files
committed
fix: Handle null value for $plotGroupingType in writePlotGroup
1 parent e63e8a9 commit d9e4f00

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: src/PhpSpreadsheet/Writer/Xlsx/Chart.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ private function writePlotArea(XMLWriter $objWriter, ?PlotArea $plotArea, ?Title
325325

326326
$chartTypes = self::getChartType($plotArea);
327327
$catIsMultiLevelSeries = $valIsMultiLevelSeries = false;
328-
$plotGroupingType = '';
328+
$plotGroupingType = null;
329329
$chartType = null;
330330
foreach ($chartTypes as $chartType) {
331331
$objWriter->startElement('c:' . $chartType);
@@ -367,7 +367,7 @@ private function writePlotArea(XMLWriter $objWriter, ?PlotArea $plotArea, ?Title
367367
$objWriter->writeAttribute('val', '150');
368368
$objWriter->endElement();
369369

370-
if ($plotGroupingType == 'percentStacked' || $plotGroupingType == 'stacked') {
370+
if ($plotGroupingType === 'percentStacked' || $plotGroupingType === 'stacked') {
371371
$objWriter->startElement('c:overlap');
372372
$objWriter->writeAttribute('val', '100');
373373
$objWriter->endElement();
@@ -1110,9 +1110,9 @@ private function writePlotSeriesValuesElement(XMLWriter $objWriter, int $val, ?C
11101110
* @param string $groupType Type of plot for dataseries
11111111
* @param bool $catIsMultiLevelSeries Is category a multi-series category
11121112
* @param bool $valIsMultiLevelSeries Is value set a multi-series set
1113-
* @param string $plotGroupingType Type of grouping for multi-series values
1113+
* @param string|null $plotGroupingType Type of grouping for multi-series values
11141114
*/
1115-
private function writePlotGroup(?DataSeries $plotGroup, string $groupType, XMLWriter $objWriter, bool &$catIsMultiLevelSeries, bool &$valIsMultiLevelSeries, string &$plotGroupingType): void
1115+
private function writePlotGroup(?DataSeries $plotGroup, string $groupType, XMLWriter $objWriter, bool &$catIsMultiLevelSeries, bool &$valIsMultiLevelSeries, ?string &$plotGroupingType): void
11161116
{
11171117
if ($plotGroup === null) {
11181118
return;

0 commit comments

Comments
 (0)