fix replies: true not working

Author: Owen3H

README.md

@@ -24,7 +24,6 @@ The [Syndication API](https://syndication.twitter.com/srv/timeline-profile/scree
 
 #### ❌ Limitations
 - When getting a Timeline, only up to `100` Tweets can be returned. (May be `20` in some cases)
-- Replies endpoint is currently broken and `replies: true` will not return anything.
 
 ## Authentication
 Twitter is now known to require a cookie to return any data!<br>
@@ -137,7 +136,8 @@ Timeline.disablePuppeteer()
 ```
 
 ## Disclaimer
-By using this library, you must do so at your own discretion.<br>
+You **must** use this library at your own discretion!
+
 I will not be held accountable for any outcomes that may result from its usage, including and not limited to:
 - Banning/Suspension of your Twitter account.
 - Lawsuits, fines and other Twitter related legal disputes.

src/classes/timeline.ts

@@ -119,7 +119,7 @@ export default class Timeline {
         options: Partial<TweetOptions> = {}
     ) {
         // Since `replies` could be `any` when compiled, check defined with !!
-        const endpoint = `${this.url}${username}?showReplies=${!!options.replies}`
+        const endpoint = `${this.url}${username}`
 
         try {
             const parsedCookie = typeof options.cookie === 'string' 
@@ -185,7 +185,7 @@ class TimelineTweet {
         return this.text.startsWith('RT @')
     }
 
-    get isReply() { 
+    get isReply() {
         return !!this.inReplyToName
     }
 }

src/tests/timeline.test.ts

@@ -18,28 +18,30 @@ describe('Timeline get', async () => {
     const cookie = process.env.TWITTER_COOKIE
     expect(cookie).toBeDefined()
 
-    it.skip('timeline can be retrieved after cutoff', async () => {
-        let timeline = []
-
-        try {
-            timeline = await Timeline.get('elonmusk')
-        } catch(e) {
-            console.error(e)
-        } finally {
-            expect(timeline).toBeDefined()
-            assertType<TimelineTweet[]>(timeline)
-            expect(timeline.length).toBeGreaterThan(0)
-
-            const latestTweetDate = new Date(timeline[0].createdAt).getTime()
-            expect(latestTweetDate / 1000).toBeGreaterThan(1651363200)
-        }
-    })
+    // it.skip('timeline can be retrieved after cutoff', async () => {
+    //     let timeline = []
+
+    //     try {
+    //         timeline = await Timeline.get('elonmusk')
+    //     } catch(e) {
+    //         console.error(e)
+    //     } finally {
+    //         expect(timeline).toBeTruthy()
+    //         expect(timeline).toBeDefined()
+    //         assertType<TimelineTweet[]>(timeline)
+    //         expect(timeline.length).toBeGreaterThan(0)
+
+    //         const latestTweetDate = new Date(timeline[0].createdAt).getTime()
+    //         expect(latestTweetDate / 1000).toBeGreaterThan(1651363200)
+    //     }
+    // })
 
     it('can use puppeteer with no config', async () => {
         await Timeline.usePuppeteer()
         const timeline = await Timeline.get('elonmusk', { cookie })
         Timeline.disablePuppeteer()
 
+        expect(timeline).toBeTruthy()
         expect(timeline).toBeDefined()
         assertType<TimelineTweet[]>(timeline)
         expect(timeline.length).toBeGreaterThan(0)
@@ -98,6 +100,7 @@ describe('Timeline get', async () => {
             try {
                 timeline = await Timeline.get('rileyreidx3', { cookie })
             } finally {
+                expect(timeline).toBeTruthy()
                 expect(timeline).toBeDefined()
                 assertType<TimelineTweet[]>(timeline)
                 expect(timeline.length).toBeGreaterThan(0)

src/util.ts

@@ -27,9 +27,7 @@ const buildCookieString = (cookies: TwitterCookies) => {
     }
 
     let str = ""
-    Object.entries(obj).forEach(e => {
-        str += `${e[0]}=${e[1]}; `
-    })
+    Object.entries(obj).forEach(e => str += `${e[0]}=${e[1]}; `)
 
     return str.trimEnd()
 }

tsconfig.json

@@ -1,8 +1,8 @@
 {
     "compilerOptions": {
         "module": "NodeNext",
-        "target": "ES2017",
         "moduleResolution": "NodeNext",
+        "target": "ES2017",
         "outDir": "dist",
         "types": ["node"],
         "skipDefaultLibCheck": true,
@@ -13,6 +13,7 @@
         "noEmitOnError": true,
         "strictFunctionTypes": true,
         "baseUrl": ".",
+        "removeComments": true,
         "paths": {
             "tslib" : ["node_modules/tslib/tslib.d.ts"]
         }