Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Apollo 2 #19

Open
eric-burel opened this issue Jul 10, 2019 · 1 comment
Open

Update to Apollo 2 #19

eric-burel opened this issue Jul 10, 2019 · 1 comment

Comments

@eric-burel
Copy link

Hi,
You can't call withRenderContext and register middleware using networkInterface anymore client side.

I am working on an update with Apollo 2, using Links. This needs some improvements because you can't add links on the fly with apollo 2.

See apollographql/apollo-client#4555

@eric-burel
Copy link
Author

Hi @ochicf
Can you confirm me what this code is supposed to do:
https://github.com/OrigenStudio/vulcan-files/blob/master/lib/server/uploadMiddleware.js#L12

To my best understanding, it remaps the files in the query to the vulcan document content. However I am not sure what asyncBusboy is supposed to do? Calling it will lead to a BadRequestError: Missing multipart field ‘operations’ **(https://github.com/jaydenseric/graphql-multipart-request-spec)** error.

I may eventually ditch this middleware and directly improve the onInsert / onEdit handler, I don't know yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant