Re: Newtonsoft what was the reasoning for Legacy

[mwpowellhtx]

I see there were some efforts, apparently, to transition to core System based Json serialization? Newtonsoft was not getting the job done, or what was the story behind that, please...

Perhaps also elaborate a bit on the comments concerning serialization of incomplete amounts.

Thank you.

[bleroy]

System can be much faster and allocate less memory, so I wanted to try it out, but the timing wasn't right, and Orchard Core itself has not made that transition. In the end there wasn't much point in doing it, so I reverted it.

[bleroy]

So currently, Orchard Core still relies mostly on Newtonsoft, but the goal eventually is to use System.Text.Json. That means that it makes sense for Core Commerce to have both types of converters maintained in the codebase to be ready for that transition, whenever it happens even if that means a little additional maintenance overhead.

[mwpowellhtx]

@bleroy Well, that's the clarification, I suppose. There is definitely a limited dependency there, and a 'legacy' usage (quot unquote), but I think if you examine a little further, not all the serialization has that, and is in fact using the System.Text.Json. Which is fine, either way, I was just curious more than anything else. If there was an advantage one way or another, might be interesting to learn what that was/is moving forward. Anyway, thanks for looking into it a bit.

[bleroy]

Hahahaha. Indeed, some objects have only System.Text.Json support. Objects that don't interact with the underlying Orchard Core infrastructure, and as such don't have the same requirements.

[mwpowellhtx]

For scope I counted perhaps two classes which had 'legacy' alternatives. Any of the others were System. 🍻 Cheers.

[bleroy]

Yes, amounts and addresses need to be persisted as properties of content parts, for which persistence is handled by Orchard Core, so Newtonsoft support is necessary. For types that are not used as content part or field properties, we handle the serialization 100% and as such only need System.