[#451] Upload the IPA of DesignToolbox to the publication store #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pylapp
requested changes
Feb 12, 2025
| @@ -34,6 +34,10 @@ APPLE_KEY_CONTENT = ENV["OUDS_APPLE_KEY_CONTENT"] | |||
| # Bundle identifier of the app | |||
| DEVELOPER_APP_IDENTIFIER = ENV["OUDS_DEVELOPER_BUNDLE_IDENTIFIER"] | |||
|
|
|||
| # Upload To Store | |||
| # --------------- | |||
There was a problem hiding this comment.
La ligne 38 ne sert à rien, tu peux la retirer :)
|
|
||
| publish_mattermost_notification("📦 ✅ @here The upload to store has been done successfully (version = '#{version}', build number = '#{build_number}')") | ||
| rescue => error | ||
| publish_mattermost_notification("📦 🚨 @channel Some issue occurred during the upload step (:upload_2_store)") |
There was a problem hiding this comment.
Il faudrait indenter ce qu'il y a dans rescue, à savoir les lignes 458 et 459
| # PRIVATE LANE UPLOAD TO STORE | ||
| # ---------------------------- | ||
| desc "PRIVATE LANE UPLOAD TO STORE" | ||
| private_lane :upload_2_store do |params| |
| # --------------------------------------------------------------------------- | ||
| desc "PRIVATE LANE UPLOAD TO TESTFLIGHT" | ||
| private_lane :upload do |params| | ||
| private_lane :upload_2_testflight do |params| |
There was a problem hiding this comment.
Plutôt upload_to_testflight non ?
| build_number = get_build_number(xcodeproj: OUDS_PROJECT) | ||
| puts "ℹ️ App build number: '#{build_number}'" | ||
|
|
||
| sh "curl -F 'file=@build/oudsApp.xcarchive' '#{UPLOAD_STORE_URL}'" |
There was a problem hiding this comment.
On est sûr que l'on a bien quelque chose à "file=@build/oudsApp.xcarchive" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
#451
Description
Add a curl command in the upload process. This is done in a specific function.
Motivation & Context
Types of change
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)