Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] GitHub to GitLab demo app migration #187

Open
2 of 14 tasks
pylapp opened this issue Oct 10, 2024 · 3 comments
Open
2 of 14 tasks

[Tooling] GitHub to GitLab demo app migration #187

pylapp opened this issue Oct 10, 2024 · 3 comments
Assignees
Labels
💥 blocking Issue can go further and is blocked by something ⚠️ on hold Not blocked but should not be processed yet 🔍 triage A new issue that needs to be treated

Comments

@pylapp
Copy link
Member

pylapp commented Oct 10, 2024

Description

Today the whole project is hosted on GitHub, under MIT open source license or (proprietary for assets if noticed), except the CI/CD chain.
However the aim of OUDS is to expose also some brand themes like, we hope, Sosh, Parnasse, Innovation Cup, or other themes, and some of these themes may remain closed source under proprietary license and hosted in our internal GitLab forges so as to not expose assets, fonts, images or other resources.

Thus, we will have to make a migration, maybe for the v1 release, to GitLab for the demo app and keep there the CI/CD chain.
Today only alpha, beta and prod builds are made in our own runners in internal forge so as to keep the Apple certificates secrets and localy stored.

Because the update of the CI/CD chain and the migration of projects is a boring, time consuming and heavy task, it must be done if and only if some prerequisites are filled.

Definition of Ready

Definiton of Done

  • Create in our GitLab a new project hosting the demo app (ouds-design-toolbokx)
  • Close the old project for the CI/CD (ouds-ios-app-distribution)
  • Migrate the demo app from GitHub to GitLab
  • Update the GitLab CI chain to make alpha builds
  • Update the GitLab CI chain to make beta builds
  • Update the GitLab CI chain to make production builds
  • Update the GitLab CI chain to leave tags on Swift package for nightly builds
  • Prune the GItHub project so as to convert it as a "pure" Swift Package project, without demo app, NOTICES etx.
  • Update the GitHub Action to run only builds and tests but not UI tests anymore
  • Ensure we can use SwiftLint, Periphery, SwiftFormat, unit tests and documentation build for Swift Package
  • Ensure we can use SwiftLint, Periphery, SwiftFormat and UI tests for design toolbox

Some details

  • The GitHub repo must contain only the Swift Package
  • We can keep ci and TestFlight tags for this repository so as to know which version has been shipped in nighlty process
  • Release tags are done on the GitHub repository
  • For the demo app we can give it the same versions as the lib (i.e. if lib x.y.z app is x.y.z)
  • We keep alpha, beta and prod builds for the demo app
  • For developement of features and fixes, given an issue number K with a branch K-foo-bar, both the demo app and the lib must have these branches.
  • Alpha builds will consist on swiching to the suitable branch in the demo app, which points to the suitable branch on GitHub
  • If we canot run tests or build doc on the Swift Package side, we will create a fake demo app just to fill these needs
@pylapp pylapp self-assigned this Oct 10, 2024
@pylapp pylapp changed the title [Tooling] GitHub to GitLab migration [Tooling] GitHub to GitLab demo app migration Oct 10, 2024
@pylapp pylapp added 💥 blocking Issue can go further and is blocked by something 🔍 triage A new issue that needs to be treated labels Oct 10, 2024
@pylapp
Copy link
Member Author

pylapp commented Oct 10, 2024

blocking beecause prerequisites are not filled, see definition fo ready

@pylapp
Copy link
Member Author

pylapp commented Oct 10, 2024

cc @B3nz01d @ludovic35

@pylapp pylapp added the ⚠️ on hold Not blocked but should not be processed yet label Oct 25, 2024
@pylapp
Copy link
Member Author

pylapp commented Oct 25, 2024

on hold as this is not mandatory at all, move to GitLab will imply to refactor the CI/CD pipelines and find workarounds for the alpha releases where the app will have to point to the SDK with the needed branch to test. Or maybe we will have to ensure the app will point to whatever the branch of the lib is, but in its own branche to compile.

@pylapp pylapp moved this from Triage to Todo in ⚛️ [OUDS] Project Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 blocking Issue can go further and is blocked by something ⚠️ on hold Not blocked but should not be processed yet 🔍 triage A new issue that needs to be treated
Projects
Development

No branches or pull requests

1 participant