Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

do not send "wallet" socket when funding an order from an external wallet #647

Open
rmisio opened this issue Aug 24, 2017 · 1 comment
Open
Labels

Comments

@rmisio
Copy link
Collaborator

rmisio commented Aug 24, 2017

Funding an order from an external wallet results in a "wallet" socket:

image

The "wallet" socket is intended to monitor transactions of the internal wallet. Funding an order from an external wallet doesn't affect the transactions of the internal wallet. When you get a "wallet" socket in this case, it results in a false positive for clients thinking a user has a new internal wallet transaction, when they do not.

@rmisio
Copy link
Collaborator Author

rmisio commented Aug 29, 2017

FWIW, @cpacia and I discussed having separate sockets for transaction updates for an order vs. the wallet. In that scenario, if a transaction was from the wallet for an order, both sockets would fire.

Having the separate sockets would also solve this bug, since there would be no "wallet" socket for orders that are funded from an external wallet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants