Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Address in Purchase should Match Shipping Address #624

Open
jjeffryes opened this issue Aug 9, 2017 · 0 comments
Open

Address in Purchase should Match Shipping Address #624

jjeffryes opened this issue Aug 9, 2017 · 0 comments
Assignees

Comments

@jjeffryes
Copy link
Collaborator

The Shipping Address has the following fields:

        Name           string `json:"name"`
	Company        string `json:"company"`
	AddressLineOne string `json:"addressLineOne"`
	AddressLineTwo string `json:"addressLineTwo"`
	City           string `json:"city"`
	State          string `json:"state"`
	Country        string `json:"country"`
	PostalCode     string `json:"postalCode"`
	AddressNotes   string `json:"addressNotes"`

But the purchase API expects

        ShipTo               string  `json:"shipTo"`
	Address              string  `json:"address"`
	City                 string  `json:"city"`
	State                string  `json:"state"`
	PostalCode           string  `json:"postalCode"`
	CountryCode          string  `json:"countryCode"`
	AddressNotes         string  `json:"addressNotes"'

It would be better to make them match, so there is a 1 to 1 relationship between shipping addresses and shipping data in purchases. Currently, the company doesn't exist in the purchase unless it's put into the ShipTo or Address values, and AddressLineOne and Address LineTwo have to be added together for Address, which makes formatting that data in a UI difficult.

It would also be less confusing if all the keys had matching names, instead of "Country" vs "CountryCode", or "Name" vs. "ShipTo".

@jjeffryes jjeffryes added this to the Milestone 4 (Beta) milestone Aug 9, 2017
@hoffmabc hoffmabc removed this from the Milestone 4 (Beta) milestone Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants