Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Ethereum Integration #1092

Closed
5 tasks done
amangale opened this issue Aug 16, 2018 · 1 comment
Closed
5 tasks done

Ethereum Integration #1092

amangale opened this issue Aug 16, 2018 · 1 comment
Assignees
Labels
Epic feature Feature or enhancement to openbazaar-go

Comments

@amangale
Copy link
Collaborator

amangale commented Aug 16, 2018

High level steps for adding ethereum coin to ob-go

  • Make wallet interface coin agnostic
  • Implement the ethereum wallet based on the wallet interface
  • Modify ob-go based on the new wallet interface
  • Add Ethereum wallet to MultiWallet
  • Bring Multiwallet to ob-go

Make wallet interface coin agnostic:

Current wallet interface is UTXO based. For ethereum, the wallet interface should not have dependencies like btc.Address, chaincfg.Params etc.
(OpenBazaar/wallet-interface#4) addresses the removal of btc.Address.

Implement the ethereum wallet based on the wallet interface

This implementation lives in two repositories:
https://github.com/OpenBazaar/go-ethwallet - The implementation of wallet interface for ethereum
https://github.com/OpenBazaar/smart-contracts - The smart contracts used by the ethereum wallet for escrow/multisig functioanlity

Modify ob-go based on the new wallet interface

As the wallet interface inroduces changes to become coin agnostic, there will be changes to the ob-go code. E.g., the Childkey method now delegates the responsibility of generating a child key for multisig to the wallet implementation rather than doing it in ob-go.

Add Ethereum wallet to MultiWallet

The ethereum wallet will be added to the existing multiwallet repository.

Bring Multiwallet to ob-go

Ob-go will support multiple cryptocurrencies (BTC, BCH, LTC, ZCASH and ETH) through multiwallet.

@placer14 placer14 added feature Feature or enhancement to openbazaar-go Epic labels Aug 16, 2018
@Talkless
Copy link

Please consider implementing Ethereum support in a way to make Rootstock integration not too difficult/different.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Epic feature Feature or enhancement to openbazaar-go
Projects
None yet
Development

No branches or pull requests

4 participants