Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent redundant ClientPool.replayListenAddresses on startup #114

Open
placer14 opened this issue Dec 19, 2019 · 0 comments
Open

Prevent redundant ClientPool.replayListenAddresses on startup #114

placer14 opened this issue Dec 19, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@placer14
Copy link
Member

Our ClientPool rotation handling within runLoop pessimistically assumes that any client start is after a failure and always attempts to replayListenAddresses despite the original calls into ListenAddresses having just successfully completed. This causes our pool startup to broadcast listen addrs twice on first start.

In order to be more bandwidth efficient, we should find a way to detect whether we're recovering from a failure or not as part of our runLoop.

@placer14 placer14 added bug Something isn't working good first issue Good for newcomers labels Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant