Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refacto Inject Form - Last Part #2641

Open
MarineLeM opened this issue Mar 10, 2025 · 1 comment
Open

Refacto Inject Form - Last Part #2641

MarineLeM opened this issue Mar 10, 2025 · 1 comment
Assignees
@MarineLeM
Labels
feature use for describing a new feature to develop technical improvement Technical refactor or improvement is needed

Comments

@MarineLeM
Copy link
Contributor

Description

This issue is part of the ongoing Inject Form refactoring effort.

Part 1 :
issue : #2038
PR : #2042

Part 2 :
issue : #2172

Context of this last Part:

The inject form, used for both modification and creation, is currently implemented across two JavaScript files: InjectDefinition.js and InjectForm.js.

Goals:

  • Convert to TypeScript: Transition these files to .tsx format to leverage TypeScript's type-checking and improved development experience.
  • Simplify InjectDefinition.js: Refactor InjectDefinition.js, which currently exceeds 1000 lines, to enhance readability and maintainability.
@MarineLeM MarineLeM added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 10, 2025
@MarineLeM MarineLeM self-assigned this Mar 10, 2025
@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Mar 10, 2025
@EllynBsc
Copy link
Member

@MarineLeM this is more of a technical improvement and a feature than a bug then right ?

@EllynBsc EllynBsc added technical improvement Technical refactor or improvement is needed feature use for describing a new feature to develop and removed bug use for describing something not working as expected labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarineLeM MarineLeM

Labels
feature use for describing a new feature to develop technical improvement Technical refactor or improvement is needed
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue/2641 OpenBAS-Platform/openbas
2 participants
@MarineLeM @EllynBsc