Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change on the exception raised to bring clearer error #2624

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Change on the exception raised to bring clearer error #2624

merged 1 commit into from
Mar 7, 2025

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Mar 7, 2025 •
edited
Loading

Proposed changes

  • Change on the exception raised to bring clearer error

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Mar 7, 2025
@Dimfacion Dimfacion changed the base branch from master to release/current March 7, 2025 13:35
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.03%. Comparing base (fe75ad8) to head (01b862c).
Report is 1 commits behind head on release/current.

Files with missing lines Patch % Lines
...rc/main/java/io/openbas/service/ImportService.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##             release/current    #2624   +/-   ##
==================================================
  Coverage              40.03%   40.03%           
  Complexity              2026     2026           
==================================================
  Files                    631      631           
  Lines                  19087    19087           
  Branches                1296     1296           
==================================================
  Hits                    7641     7641           
  Misses                 11027    11027           
  Partials                 419      419

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dimfacion Dimfacion merged commit 0c00051 into release/current Mar 7, 2025
7 checks passed
@Dimfacion Dimfacion deleted the issue/2623 branch March 7, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savacano28 savacano28 savacano28 approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearer message in case an import scenario is in an incorrect format
2 participants
@Dimfacion @savacano28