Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical issue : Remove Contract Selection Duplication #2579

Open
MarineLeM opened this issue Mar 3, 2025 · 0 comments
Open

Technical issue : Remove Contract Selection Duplication #2579

MarineLeM opened this issue Mar 3, 2025 · 0 comments
Labels
bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed
Milestone

Comments

@MarineLeM
Copy link
Contributor

Description

In the backend, ContractSelect and ContractChoiceInformation are both used to create a dynamic field in injectContract, but they are very similar. We can simplify this by keeping only one selection field.

However, note that the 'information' in the ContractChoiceInformation component is used for obfuscation. When creating an inject with an Atomic Red Team payload, selecting "base64" triggers an informational message. Ensure this behavior is preserved.

@MarineLeM MarineLeM added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 3, 2025
@jborozco jborozco added technical improvement Technical refactor or improvement is needed and removed needs triage use to identify issue needing triage from Filigran Product team labels Mar 4, 2025
@jborozco jborozco added this to the Bugs backlog milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed
Projects
None yet
Development

No branches or pull requests

2 participants