Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] Add UI installation steppers #2466

Open
wants to merge 55 commits into
base: release/current
Choose a base branch
from
Open

[backend/frontend] Add UI installation steppers #2466

wants to merge 55 commits into from

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Feb 17, 2025 •
edited
Loading

Proposed changes

  • Update UI with the differents installation modes for the agents
  • Fix style icons in endpoint list/endpoint overview
  • Fix Stepper payload creation
  • Add upper format for ips in endpoint overview

Loom: https://www.loom.com/share/6c9b801a98474f7b919fb0d08222380a?sid=306482de-f79f-4cca-b934-dff106d6d6de

! This Pr should be tested after the PR Windows Agent Installation is merged : OpenBAS-Platform/agent#58

For testing: We must verify that each script/installation corresponds to the selected installation mode.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Feb 17, 2025
@savacano28 savacano28 self-assigned this Feb 17, 2025
@savacano28 savacano28 changed the title Issue/1860 UI installation steppers [backend/frontend] Ad UI installation steppers Feb 17, 2025
@savacano28 savacano28 changed the title [backend/frontend] Ad UI installation steppers [backend/frontend] Add UI installation steppers Feb 17, 2025
@savacano28 savacano28 changed the base branch from release/current to issue/1860 February 18, 2025 08:23
@savacano28 savacano28 force-pushed the issue/1860 branch 3 times, most recently from ca16d21 to 513faed Compare February 18, 2025 14:18
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch from 99a844e to cfab2d9 Compare February 18, 2025 14:35
@savacano28 savacano28 force-pushed the issue/1860 branch 2 times, most recently from fae81ae to 77b07bc Compare February 18, 2025 15:51
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch from a094b9c to 3474736 Compare February 18, 2025 16:13
Base automatically changed from issue/1860 to release/current February 18, 2025 16:46
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch from 3474736 to 6c9e8dc Compare February 18, 2025 17:13
@savacano28 savacano28 closed this Feb 18, 2025
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch from 2ff0792 to 3374937 Compare February 18, 2025 18:20
@savacano28 savacano28 reopened this Feb 19, 2025
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch 2 times, most recently from 1353492 to 411b28f Compare February 20, 2025 09:50
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch 3 times, most recently from 72efeed to 9708cc0 Compare February 28, 2025 16:01
@savacano28 savacano28 mentioned this pull request Mar 3, 2025
Open
@savacano28 savacano28 linked an issue Mar 3, 2025 that may be closed by this pull request
In the endpoint view, agent logos are truncated #2568
Open
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch from 9708cc0 to 29fe3be Compare March 3, 2025 15:15
@savacano28 savacano28 linked an issue Mar 4, 2025 that may be closed by this pull request
UI Payload Creation Stepper doesnt work #2599
Open
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch from f8a275b to 922059b Compare March 4, 2025 16:31
@savacano28 savacano28 linked an issue Mar 4, 2025 that may be closed by this pull request
I can choose the level of privilege of my agent #1860
Open
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 26.08696% with 34 lines in your changes missing coverage. Please review.

Project coverage is 40.59%. Comparing base (f050d80) to head (c152e26).

Files with missing lines Patch % Lines
...ain/java/io/openbas/rest/executor/ExecutorApi.java 0.00% 13 Missing ⚠️
.../main/java/io/openbas/service/EndpointService.java 23.07% 10 Missing ⚠️
...ain/java/io/openbas/rest/document/DocumentApi.java 0.00% 7 Missing ⚠️
...ain/java/io/openbas/executors/ExecutorService.java 75.00% 0 Missing and 1 partial ⚠️
...cutors/caldera/service/CalderaExecutorService.java 0.00% 1 Missing ⚠️
...rowdstrike/service/CrowdStrikeExecutorService.java 0.00% 1 Missing ⚠️
...xecutors/tanium/service/TaniumExecutorService.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                  @@
##             release/current    #2466      +/-   ##
=====================================================
- Coverage              40.62%   40.59%   -0.03%     
- Complexity              2045     2047       +2     
=====================================================
  Files                    632      633       +1     
  Lines                  19103    19134      +31     
  Branches                1290     1295       +5     
=====================================================
+ Hits                    7761     7768       +7     
- Misses                 10922    10946      +24     
  Partials                 420      420

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

damgouj and others added 29 commits March 10, 2025 19:28
@savacano28 savacano28 force-pushed the issue/1860-ui-installation-steppers branch from a2c4a9a to c152e26 Compare March 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarineLeM MarineLeM MarineLeM approved these changes

Assignees

@savacano28 savacano28

Labels
filigran team use to identify PR from the Filigran team multi-repository
Projects
None yet
Milestone
No milestone
3 participants
@savacano28 @MarineLeM @damgouj