Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage asset group expectations in the same way as team expectations #1829

Open
savacano28 opened this issue Nov 8, 2024 · 2 comments
Open
Assignees
Labels
bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed
Milestone

Comments

@savacano28
Copy link
Contributor

Description

In the current system, the expectations generated for asset groups and their assets do not fill the "asset group" column for every asset expectation. This is different from the behavior with teams, where for each player expectation, the "team" column is filled with the ID of the player's parent team.

If we set the asset group for each asset expectation (if applicable), when an asset group is deleted, we will clean up the associated expectations.

To verify:

  • The global score query needs to filter on assets, asset groups, and teams.
  • We need to apply a migration script to update the expectations with the latest changes
@savacano28 savacano28 added bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed needs triage use to identify issue needing triage from Filigran Product team labels Nov 8, 2024
@savacano28 savacano28 self-assigned this Nov 8, 2024
@RomuDeuxfois
Copy link
Member

Usefull to improv performance.

@jborozco jborozco added this to the Bugs backlog milestone Nov 8, 2024
@jborozco jborozco removed the needs triage use to identify issue needing triage from Filigran Product team label Nov 12, 2024
@jborozco
Copy link

More globally and less about the perf: We need to align assets and team behaviors in a simulation (how to assign teams/assets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed
Projects
None yet
Development

No branches or pull requests

3 participants