Skip to content

Commit 2c25443

Browse files
authored
Update base image of Dockerfile (#17007)
* Update base image of Dockerfile * Make github workflow "Docker tests" manually triggerable * Don't possibly downgrade TLS version * Update Dockerimage in ``run-in-docker.sh`` * Use Maven's non interactive mode inside workflow * Don't spam log * Use java 17 because it won't compile with 21 * Removed hard memory limit as memory should be controlled by the container * Update hub dockerfiles
1 parent d1b148a commit 2c25443

6 files changed

+13
-12
lines changed

.github/workflows/docker.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: Docker tests
22

33
on:
4+
workflow_dispatch:
45
push:
56
paths:
67
- Dockerfile
@@ -27,7 +28,7 @@ jobs:
2728
shell: bash
2829
run: |
2930
sed -i 's/ -it / /g' run-in-docker.sh
30-
./run-in-docker.sh mvn clean install
31+
./run-in-docker.sh mvn -B clean install
3132
3233
- name: Build Dockerfile
3334
shell: bash

.hub.cli.dockerfile

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,19 @@
33
##
44
## You can build _just_ this part with:
55
## docker --target builder -t container-name:builder -f .hub.cli.dockerfile .
6-
FROM maven:3.6.3-jdk-11-openj9 as builder
6+
FROM maven:3-eclipse-temurin-17 as builder
77

88
ENV GEN_DIR /opt/openapi-generator
99
WORKDIR ${GEN_DIR}
1010
COPY . ${GEN_DIR}
1111

1212
# Pre-compile openapi-generator-cli
13-
RUN mvn -am -pl "modules/openapi-generator-cli" package
13+
RUN mvn -B -am -pl "modules/openapi-generator-cli" package
1414

1515
## The final (release) image
1616
## The resulting container here only needs the target jar
1717
## and ca-certificates (to be able to query HTTPS hosted specs)
18-
FROM openjdk:11.0.8-jre-slim-buster
18+
FROM eclipse-temurin:17-jre
1919

2020
ENV GEN_DIR /opt/openapi-generator
2121

.hub.online.dockerfile

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,18 @@
33
##
44
## You can build _just_ this part with:
55
## docker --target builder -t container-name:builder -f .hub.online.dockerfile .
6-
FROM maven:3.6.3-jdk-11-openj9 as builder
6+
FROM maven:3-eclipse-temurin-17 as builder
77

88
ENV GEN_DIR /opt/openapi-generator
99
WORKDIR ${GEN_DIR}
1010
COPY . ${GEN_DIR}
1111

1212
# Pre-compile openapi-generator-online
13-
RUN mvn -am -pl "modules/openapi-generator-online" package
13+
RUN mvn -B -am -pl "modules/openapi-generator-online" package
1414

1515
## The final (release) image
1616
## The resulting container here only needs the target jar
17-
FROM openjdk:11.0.8-jre-slim-buster
17+
FROM eclipse-temurin:17-jre
1818

1919
ENV GEN_DIR /opt/openapi-generator
2020
ENV TARGET_DIR /generator

Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM maven:3.6.3-jdk-11-openj9
1+
FROM maven:3-eclipse-temurin-17
22

33
ENV GEN_DIR /opt/openapi-generator
44
WORKDIR ${GEN_DIR}
@@ -20,7 +20,7 @@ COPY ./modules/openapi-generator ${GEN_DIR}/modules/openapi-generator
2020
COPY ./pom.xml ${GEN_DIR}
2121

2222
# Pre-compile openapi-generator-cli
23-
RUN mvn -am -pl "modules/openapi-generator-cli" package
23+
RUN mvn -B -am -pl "modules/openapi-generator-cli" package
2424

2525
# This exists at the end of the file to benefit from cached layers when modifying docker-entrypoint.sh.
2626
COPY docker-entrypoint.sh /usr/local/bin/

docker-entrypoint.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -euo pipefail
44

55
# GEN_DIR allows to share the entrypoint between Dockerfile and run-in-docker.sh (backward compatible)
66
GEN_DIR=${GEN_DIR:-/opt/openapi-generator}
7-
JAVA_OPTS=${JAVA_OPTS:-"-Xmx1024M -DloggerPath=conf/log4j.properties"}
7+
JAVA_OPTS=${JAVA_OPTS:-"-DloggerPath=conf/log4j.properties"}
88

99
cli="${GEN_DIR}/modules/openapi-generator-cli"
1010
codegen="${cli}/target/openapi-generator-cli.jar"

run-in-docker.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ docker run --rm -it \
1515
-w /gen \
1616
-e GEN_DIR=/gen \
1717
-e MAVEN_CONFIG=/var/maven/.m2 \
18-
-e MAVEN_OPTS="-Dhttps.protocols=TLSv1.2 -Dmaven.repo.local=/var/maven/.m2/repository -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=WARN -Dorg.slf4j.simpleLogger.showDateTime=true -Djava.awt.headless=true -Djacoco.skip=true" \
18+
-e MAVEN_OPTS="-Dmaven.repo.local=/var/maven/.m2/repository -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=WARN -Dorg.slf4j.simpleLogger.showDateTime=true -Djava.awt.headless=true -Djacoco.skip=true" \
1919
-u "$(id -u):$(id -g)" \
2020
-v "${PWD}:/gen" \
2121
-v "${PWD}/CI/run-in-docker-settings.xml:/var/maven/.m2/settings.xml" \
2222
-v "${maven_cache_repo}:/var/maven/.m2/repository" \
2323
--entrypoint /gen/docker-entrypoint.sh \
24-
maven:3-jdk-11 "$@"
24+
maven:3-eclipse-temurin-17 "$@"

0 commit comments

Comments
 (0)