Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive for type if only the format is changed. #248

Open
stefanvitz opened this issue Jul 13, 2021 · 2 comments
Open

false positive for type if only the format is changed. #248

stefanvitz opened this issue Jul 13, 2021 · 2 comments

Comments

@stefanvitz
Copy link

i changed the format of a string property.
e.g. when generated out of java and the propery is now mapped via Spring from a String to a UUID.

Perhaps it's correct to report a change. but the change is not on the type but on the format.
and therefore userUid (string -> string) does not help.

old

"ServicePageInteractionRequest":{
   "type":"object",
   "properties":{
      "userUid":{
         "type":"string"
      },
      ...
   }
}

new

"ServicePageInteractionRequest" : {
   "type" : "object",
   "properties" : {
      "userUid" : {
         "type" : "string",
         "format" : "uuid",
         "example" : "5412185d-2cf1-46d0-85d3-50bfc93b1122"
       },
      ...
   }
}

report:

Changed property type: userUid (string -> string)
@stefanvitz
Copy link
Author

might be related to #192 but the changes were different there so i decided to open a seperate issue.

@M0dM
Copy link

M0dM commented Feb 18, 2022

I am not very used to work in java, but adding a breakpoint on this line might help to understand the issue:

|| !Objects.equals(left.getType(), right.getType())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants