Skip to content

Commit 0a9fade

Browse files
authored
Merge pull request #98 from OneSignal/cd_update
Generator Update
2 parents 64d9c95 + e70a3be commit 0a9fade

26 files changed

+3889
-14940
lines changed

.github/ISSUE_TEMPLATE/ask-question.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: 🙋‍♂️ Ask a question
22
description: Tell us what's on your mind
3-
title: "[question]: "
3+
title: "[Question]: "
44
labels: ["triage"]
55
assignees:
66
- OneSignal/eng-developer-sdk

.github/ISSUE_TEMPLATE/bug-report.yml

+24
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,29 @@ body:
1717
placeholder: The latest version of the SDK causes a runtime error.
1818
validations:
1919
required: true
20+
- type: dropdown
21+
id: browsers
22+
attributes:
23+
label: What browsers are you seeing the problem on?
24+
multiple: true
25+
options:
26+
- Firefox
27+
- Chrome (Chromium)
28+
- Safari
29+
- Microsoft Edge
30+
- Opera
31+
- Brave
32+
- Other
33+
validations:
34+
required: true
35+
- type: input
36+
id: operating-system
37+
attributes:
38+
label: What operating system are you running?
39+
description: Make sure to include the version.
40+
placeholder: macOS Monterey 12.3.1
41+
validations:
42+
required: true
2043
- type: textarea
2144
id: reproduction-steps
2245
attributes:
@@ -44,3 +67,4 @@ body:
4467
label: Relevant log output
4568
description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
4669
render: Shell
70+

.github/ISSUE_TEMPLATE/general-feedback.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: 📣 General feedback
22
description: Tell us what's on your mind
3-
title: "[Bug]: "
3+
title: "[Feedback]: "
44
labels: ["triage"]
55
assignees:
66
- OneSignal/eng-developer-sdk
File renamed without changes.

MigrationGuide.md

+320-64
Large diffs are not rendered by default.

README.md

+8-17
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,14 @@
1-
<h1 align="center">Welcome to react-onesignal 👋</h1>
2-
<p>
3-
<a href="https://www.npmjs.com/package/react-onesignal" target="_blank">
4-
<img alt="Version" src="https://img.shields.io/npm/v/react-onesignal.svg">
5-
</a>
6-
<a href="https://github.com/OneSignal/react-onesignal#readme" target="_blank">
7-
<img alt="Documentation" src="https://img.shields.io/badge/documentation-yes-brightgreen.svg" />
8-
</a>
9-
<a href="https://github.com/OneSignal/react-onesignal/graphs/commit-activity" target="_blank">
10-
<img alt="Maintenance" src="https://img.shields.io/badge/Maintained%3F-yes-green.svg" />
11-
</a>
12-
<a href="https://twitter.com/onesignal" target="_blank">
13-
<img alt="Twitter: onesignal" src="https://img.shields.io/twitter/follow/onesignal.svg?style=social" />
14-
</a>
1+
<p align="center">
2+
<img src="https://media.onesignal.com/cms/Website%20Layout/logo-red.svg"/>
3+
<br/>
4+
<br/>
5+
<span style="color: grey !important">Showing web push notifications from Chrome, Safari, and Firefox</span>
156
</p>
167

17-
> This is a JavaScript module that can be used to easily include [OneSignal](https://onesignal.com/) code in a website or app that uses React for its front-end codebase.
8+
# React OneSignal
9+
---
1810

19-
* 🏠 [Homepage](https://github.com/OneSignal/react-onesignal#readme)
20-
* 🖤 [npm](https://www.npmjs.com/package/react-onesignal)
11+
This is a JavaScript module that can be used to easily include [OneSignal](https://onesignal.com/) code in a website or app that uses React for its front-end codebase.
2112

2213
OneSignal is the world's leader for Mobile Push Notifications, Web Push, and In-App Messaging. It is trusted by 800k businesses to send 5 billion Push Notifications per day.
2314

example/.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,6 @@
2121
npm-debug.log*
2222
yarn-debug.log*
2323
yarn-error.log*
24+
25+
dev-ssl.crt
26+
dev-ssl.key

example/README.md

+7-31
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ In the project directory, you can run:
99
### `npm start`
1010

1111
Runs the app in the development mode.\
12-
Open [http://localhost:3000](http://localhost:3000) to view it in your browser.
12+
Open [http://localhost:3000](http://localhost:3000) to view it in the browser.
1313

14-
The page will reload when you make changes.\
15-
You may also see any lint errors in the console.
14+
The page will reload if you make edits.\
15+
You will also see any lint errors in the console.
1616

1717
### `npm test`
1818

@@ -31,40 +31,16 @@ See the section about [deployment](https://facebook.github.io/create-react-app/d
3131

3232
### `npm run eject`
3333

34-
**Note: this is a one-way operation. Once you `eject`, you can't go back!**
34+
**Note: this is a one-way operation. Once you `eject`, you cant go back!**
3535

36-
If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.
36+
If you arent satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.
3737

38-
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own.
38+
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point youre on your own.
3939

40-
You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it.
40+
You dont have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldnt feel obligated to use this feature. However we understand that this tool wouldnt be useful if you couldnt customize it when you are ready for it.
4141

4242
## Learn More
4343

4444
You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).
4545

4646
To learn React, check out the [React documentation](https://reactjs.org/).
47-
48-
### Code Splitting
49-
50-
This section has moved here: [https://facebook.github.io/create-react-app/docs/code-splitting](https://facebook.github.io/create-react-app/docs/code-splitting)
51-
52-
### Analyzing the Bundle Size
53-
54-
This section has moved here: [https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size](https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size)
55-
56-
### Making a Progressive Web App
57-
58-
This section has moved here: [https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app](https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app)
59-
60-
### Advanced Configuration
61-
62-
This section has moved here: [https://facebook.github.io/create-react-app/docs/advanced-configuration](https://facebook.github.io/create-react-app/docs/advanced-configuration)
63-
64-
### Deployment
65-
66-
This section has moved here: [https://facebook.github.io/create-react-app/docs/deployment](https://facebook.github.io/create-react-app/docs/deployment)
67-
68-
### `npm run build` fails to minify
69-
70-
This section has moved here: [https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify](https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify)

0 commit comments

Comments
 (0)