Skip to content

Commit ddea65a

Browse files
authored
chore: update vs m365 getStatus (#5313)
1 parent bb3f551 commit ddea65a

File tree

3 files changed

+9
-31
lines changed

3 files changed

+9
-31
lines changed

.azure-pipelines/CredScanSuppressions.json

+4
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@
3636
{
3737
"placeholder": "crypto_025d3c0a85c31e192ff0d8b8d0c9f44e3d5044fa95e642ce6c46d8ee5c4e2ad6b90c3ab385589e7c0d52862898efea47433586f4a14c9f899a7769b3ec73eff372161bbe4b98eb8ba928d58a4ad942bfc880585fe0de737c2f3e5d1a0509e844a4adaf55fa8dd0ecd1e6b3f52dc9812cf6bebb0e",
3838
"_justification": "This is the secret place holder used by TeamsFx project."
39+
},
40+
{
41+
"placeholder": "user!",
42+
"_justification": "This is the secret place holder used by TeamsFx project."
3943
}
4044
]
4145
}

packages/server/src/apis.ts

+3-24
Original file line numberDiff line numberDiff line change
@@ -163,37 +163,16 @@ export const RequestTypes = {
163163
`${Namespaces.Azure}/getSelectedSubscriptionRequest`
164164
),
165165
},
166-
[Namespaces.Graph]: {
167-
getAccessToken: new RequestType0<Result<string, FxError>, Error>(
168-
`${Namespaces.Graph}/getAccessTokenRequest`
169-
),
170-
getJsonObject: new RequestType0<Result<string, FxError>, Error>(
171-
`${Namespaces.Graph}/getJsonObjectRequest`
172-
),
173-
},
174-
[Namespaces.AppStudio]: {
175-
getAccessToken: new RequestType0<Result<string, FxError>, Error>(
176-
`${Namespaces.AppStudio}/getAccessTokenRequest`
177-
),
178-
getJsonObject: new RequestType0<Result<string, FxError>, Error>(
179-
`${Namespaces.AppStudio}/getJsonObjectRequest`
180-
),
181-
},
182-
[Namespaces.SharePoint]: {
183-
getAccessToken: new RequestType0<Result<string, FxError>, Error>(
184-
`${Namespaces.SharePoint}/getAccessTokenRequest`
185-
),
186-
getJsonObject: new RequestType0<Result<string, FxError>, Error>(
187-
`${Namespaces.SharePoint}/getJsonObjectRequest`
188-
),
189-
},
190166
[Namespaces.M365]: {
191167
getAccessToken: new RequestType1<TokenRequest, Result<string, FxError>, Error>(
192168
`${Namespaces.M365}/getAccessTokenRequest`
193169
),
194170
getJsonObject: new RequestType1<TokenRequest, Result<string, FxError>, Error>(
195171
`${Namespaces.M365}/getJsonObjectRequest`
196172
),
173+
getStatus: new RequestType1<TokenRequest, Result<LoginStatus, FxError>, Error>(
174+
`${Namespaces.M365}/getStatusRequest`
175+
),
197176
},
198177

199178
/**

packages/server/src/providers/token/m365.ts

+2-7
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,12 @@ export default class ServerM365TokenProvider implements M365TokenProvider {
4646
}
4747

4848
async getStatus(tokenRequest: TokenRequest): Promise<Result<LoginStatus, FxError>> {
49-
const promise = this.connection.sendRequest(RequestTypes.m365.getAccessToken, tokenRequest);
49+
const promise = this.connection.sendRequest(RequestTypes.m365.getStatus, tokenRequest);
5050
const result = await getResponseWithErrorHandling(promise);
5151
if (result.isErr()) {
5252
return err(result.error);
5353
}
54-
const jsonPromise = this.connection.sendRequest(RequestTypes.m365.getJsonObject, tokenRequest);
55-
const jsonResult = await getResponseWithErrorHandling(jsonPromise);
56-
if (jsonResult.isErr()) {
57-
return err(jsonResult.error);
58-
}
59-
return ok({ status: signedIn, token: result.value, accountInfo: JSON.parse(jsonResult.value) });
54+
return ok(result.value);
6055
}
6156

6257
async signout(): Promise<boolean> {

0 commit comments

Comments
 (0)