fix: remove axios dependency (#10389)

Author: jayzhang

packages/manifest/package.json

@@ -8,7 +8,6 @@
     "@types/fs-extra": "^11.0.1",
     "ajv": "^8.5.0",
     "ajv-draft-04": "^1.0.0",
-    "axios": "^0.21.2",
     "fs-extra": "^9.1.0"
   },
   "devDependencies": {

packages/manifest/src/index.ts

@@ -5,7 +5,6 @@ import { TeamsAppManifest, IComposeExtension } from "./manifest";
 import fs from "fs-extra";
 import Ajv from "ajv-draft-04";
 import { JSONSchemaType } from "ajv";
-import axios, { AxiosResponse } from "axios";
 import { DevPreviewSchema } from "./devPreviewManifest";
 import { ManifestCommonProperties } from "./ManifestCommonProperties";
 import { SharePointAppId } from "./constants";
@@ -68,34 +67,40 @@ export class ManifestUtil {
     }
   }
 
-  /**
-   * Validate manifest against {@link TeamsAppManifest#$schema}.
-   *
-   * @param manifest - Manifest object to be validated
-   * @throws Will throw if {@link TeamsAppManifest#$schema} is undefined, not valid
-   *         or there is any network failure when getting the schema.
-   *
-   * @returns An empty array if schema validation passes, or an array of error string otherwise.
-   */
-  static async validateManifest<T extends Manifest = TeamsAppManifest>(
+  static async fetchSchema<T extends Manifest = TeamsAppManifest>(
     manifest: T
-  ): Promise<string[]> {
+  ): Promise<JSONSchemaType<T>> {
     if (!manifest.$schema) {
       throw new Error("Manifest does not have a $schema property");
     }
-    let result: AxiosResponse<any>;
+    let result: JSONSchemaType<T>;
     try {
-      const axiosInstance = axios.create();
-      result = await axiosInstance.get(manifest.$schema);
+      const res = await fetch(manifest.$schema);
+      result = (await res.json()) as JSONSchemaType<T>;
     } catch (e: unknown) {
       if (e instanceof Error) {
         throw new Error(`Failed to get manifest at url ${manifest.$schema} due to: ${e.message}`);
       } else {
         throw new Error(`Failed to get manifest at url ${manifest.$schema} due to: unknown error`);
       }
     }
+    return result;
+  }
 
-    return ManifestUtil.validateManifestAgainstSchema(manifest, result.data);
+  /**
+   * Validate manifest against {@link TeamsAppManifest#$schema}.
+   *
+   * @param manifest - Manifest object to be validated
+   * @throws Will throw if {@link TeamsAppManifest#$schema} is undefined, not valid
+   *         or there is any network failure when getting the schema.
+   *
+   * @returns An empty array if schema validation passes, or an array of error string otherwise.
+   */
+  static async validateManifest<T extends Manifest = TeamsAppManifest>(
+    manifest: T
+  ): Promise<string[]> {
+    const schema = await this.fetchSchema(manifest);
+    return ManifestUtil.validateManifestAgainstSchema(manifest, schema);
   }
 
   /**

packages/manifest/test/index.test.ts

@@ -4,7 +4,6 @@ import * as path from "path";
 import fs from "fs-extra";
 import chaiAsPromised from "chai-as-promised";
 import sinon from "sinon";
-import axios, { AxiosInstance, AxiosRequestConfig, AxiosResponse, AxiosPromise } from "axios";
 import { ManifestUtil, TeamsAppManifest, TeamsAppManifestJSONSchema } from "../src";
 chai.use(chaiAsPromised);
 
@@ -54,16 +53,11 @@ describe("Manifest manipulation", async () => {
 
   describe("validateManifest", async () => {
     const mocker = sinon.createSandbox();
-    const axiosInstanceMock = createMockedAxiosInstance();
-    axiosInstanceMock.get = async function <T = any, R = AxiosResponse<T>>(
-      url: string,
-      config?: AxiosRequestConfig
-    ): Promise<R> {
-      return { data: loadSchema() } as unknown as R;
-    };
+
+    const schema = await loadSchema();
 
     before(() => {
-      mocker.stub(axios, "create").returns(axiosInstanceMock);
+      mocker.stub(ManifestUtil, "fetchSchema").resolves(schema);
     });
 
     after(() => {
@@ -111,66 +105,3 @@ async function loadSchema(): Promise<TeamsAppManifestJSONSchema> {
   const schemaPath = path.join(__dirname, "MicrosoftTeams.schema.json");
   return fs.readJson(schemaPath);
 }
-
-function createMockedAxiosInstance(): AxiosInstance {
-  const mockAxiosInstance = (url: string, config?: AxiosRequestConfig): AxiosPromise => {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.defaults = axios.defaults;
-  mockAxiosInstance.interceptors = axios.interceptors;
-  mockAxiosInstance.getUri = (config?: AxiosRequestConfig): string => {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.request = function <T = any, R = AxiosResponse<T>>(
-    config: AxiosRequestConfig
-  ): Promise<R> {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.get = function <T = any, R = AxiosResponse<T>>(
-    url: string,
-    config?: AxiosRequestConfig
-  ): Promise<R> {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.delete = function <T = any, R = AxiosResponse<T>>(
-    url: string,
-    config?: AxiosRequestConfig
-  ): Promise<R> {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.head = function <T = any, R = AxiosResponse<T>>(
-    url: string,
-    config?: AxiosRequestConfig
-  ): Promise<R> {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.options = function <T = any, R = AxiosResponse<T>>(
-    url: string,
-    config?: AxiosRequestConfig
-  ): Promise<R> {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.post = function <T = any, R = AxiosResponse<T>>(
-    url: string,
-    data?: any,
-    config?: AxiosRequestConfig
-  ): Promise<R> {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.put = function <T = any, R = AxiosResponse<T>>(
-    url: string,
-    data?: any,
-    config?: AxiosRequestConfig
-  ): Promise<R> {
-    throw new Error("Method not implemented.");
-  };
-  mockAxiosInstance.patch = function <T = any, R = AxiosResponse<T>>(
-    url: string,
-    data?: any,
-    config?: AxiosRequestConfig
-  ): Promise<R> {
-    throw new Error("Method not implemented.");
-  };
-
-  return mockAxiosInstance as AxiosInstance;
-}