You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Rectangle ROI Threshold tool in TMTV mode is not functioning properly. Additionally, when attempting to fix this issue, several subsequent errors arise. It appears that in Cornerstone, the segmentationId and volumeId are now treated as separate entities, but in OHIF Viewer, we still attempt to fetch the segmentation using the volumeId (e.g., see: extensions/tmtv/src/utils/handleROIThresholding.ts#5). Here in v3.9 we got the volumeID instead of segmentationID.
Furthermore, the "Run" button required to execute the command is missing from the TMTV Segmentation Panel, preventing the tool from being fully functional.
threshold-tool.mp4
Steps to Reproduce
Launch a PT/CT data in TMTV Viewer.
Select PT Axial Viewport.
Select Rectangle ROI Threshold Tool from the segmentation panel.
Draw a rectangle in Viewport.
Click the run button
Observe the console errors.
The current behavior
The "Run" button is missing from the options in the Rectangle ROI Threshold tool. Even if the "Run" button is displayed, clicking it does not trigger the thresholding action on the slices. Additionally, console errors are being logged, which indicate underlying issues.
The expected behavior
The user should be able to segment using the Rectangle ROI Threshold tool without errors.
The Run button should display while select Rectangle ROI Threshold tool
OS
Windows 10
Node version
18.19.0
Browser
132.0.6834.160
The text was updated successfully, but these errors were encountered:
@sedghi Upon investigating the issue, it was observed that the "Run" button is not appearing due to the handling of the state (selectedSegmentationId) in RectangleROIOptions.tsx. The current implementation collects the segmentationId from the viewports; however, in the setState method, an id property is being assigned based on the format ${segmentationId}-${type}-${viewportId}, rather than directly using the segmentationId. Modifying the selectedSegmentationId to use the segmentationId directly resolved this issue.
Following this fix, a new error related to an undefined volumeId was encountered. Please refer to the attached screenshot for further details.
Describe the Bug
The Rectangle ROI Threshold tool in TMTV mode is not functioning properly. Additionally, when attempting to fix this issue, several subsequent errors arise. It appears that in Cornerstone, the segmentationId and volumeId are now treated as separate entities, but in OHIF Viewer, we still attempt to fetch the segmentation using the volumeId (e.g., see: extensions/tmtv/src/utils/handleROIThresholding.ts#5). Here in v3.9 we got the volumeID instead of segmentationID.
Furthermore, the "Run" button required to execute the command is missing from the TMTV Segmentation Panel, preventing the tool from being fully functional.
threshold-tool.mp4
Steps to Reproduce
The current behavior
The "Run" button is missing from the options in the Rectangle ROI Threshold tool. Even if the "Run" button is displayed, clicking it does not trigger the thresholding action on the slices. Additionally, console errors are being logged, which indicate underlying issues.
The expected behavior
The user should be able to segment using the Rectangle ROI Threshold tool without errors.
The Run button should display while select Rectangle ROI Threshold tool
OS
Windows 10
Node version
18.19.0
Browser
132.0.6834.160
The text was updated successfully, but these errors were encountered: