Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles refactoring #647

Open
sbidoul opened this issue Nov 10, 2024 · 0 comments
Open

Styles refactoring #647

sbidoul opened this issue Nov 10, 2024 · 0 comments
Labels
enhancement no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Comments

@sbidoul
Copy link
Member

sbidoul commented Nov 10, 2024

Styles are currently defined on

  • report template: apply to the whole report
  • kpi (aka rows): inherit report level style
  • account detail rows: inherit report level style

Style are inherited with an override mechanism when they are merged.

A more extensive approach could be this style inheritance order

  • template (mis.report): global style for the template
  • (*) report (mis.report.instance): override global style per report
  • (*) column (mis.report.instance.period): override global style per column (e.g. to set a color on comparison columns, ...)
  • (*) subkpi column (mis.report.subkpi): override column style per subkpi column
  • row (mis.report.kpi): override global an column style per row (e.g. to highlight subtotals)
  • (*) subkpi cell (mis.report.kpi.expression)

(*) not implemented yet

@sbidoul sbidoul mentioned this issue Nov 10, 2024
@sbidoul sbidoul added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

No branches or pull requests

1 participant