Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 18.0 #639

Open
3 tasks
OCA-git-bot opened this issue Oct 6, 2024 · 4 comments
Open
3 tasks

Migration to version 18.0 #639

OCA-git-bot opened this issue Oct 6, 2024 · 4 comments
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Milestone

Comments

@OCA-git-bot
Copy link
Contributor

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

  • mis_builder
  • mis_builder_budget
  • mis_builder_demo

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

@OCA-git-bot OCA-git-bot added help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress labels Oct 6, 2024
@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 6, 2024
@sbidoul
Copy link
Member

sbidoul commented Nov 10, 2024

For v18, I would like to create new security groups, and use these instead of the accounting groups to control access to MIS reports and templates:

  • MIS Report Viewer: ro access to MIS Reports
  • MIS Report Administrator: rw access to MIS Reports
  • MIS Report Template Administrator: rw access to templates and styles

For budgets:

  • MIS Budget Viewer: ro access to MIS Budgets
  • MIS Budget Administrator: rw access to MIS Budgets

@pedrobaeza
Copy link
Member

On the budgets part: does it make sense to not access MIS budgets, but see the results in a MIS report? I consider OK to have a rw access group, but ro should be the MIS base one.

@sbidoul
Copy link
Member

sbidoul commented Nov 11, 2024

It is actually possible to view MIS Reports without access to account.move.line. So, in the same spirit, since budget information can be sensitive data, I'd say it's worth a separate security group. Viewer of MIS Reports will then not be able to view reports involving budget data, but other reports will work.

@pedrobaeza
Copy link
Member

I think it will be weird to access the report, but not to be able to preview it/export it. Let's block it by access rules (or inheriting the _check_access method) for not viewing them in the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Projects
None yet
Development

No branches or pull requests

3 participants