Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] account_invoice_margin: init Invoice margins from SOs if possible #202

Merged
merged 2 commits into from
Aug 23, 2024
Merged

[IMP] account_invoice_margin: init Invoice margins from SOs if possible #202

merged 2 commits into from
Aug 23, 2024

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Apr 6, 2024 •
edited
Loading

Includes #201
Closes #182

@dreispt
[FIX] account_invoice_margin: wrong default margin calculation
bad4066 
When installing the module, the Invoice total margin initial calculation
was including all AML lines, including taxes.
This resulted in a margin of more than 100%.
@dreispt
[IMP] account_invoice_margin: init Invoice margins from SOs if possible
e91d51f
@OCA-git-bot
Copy link
Contributor

Hi @sergio-teruel,
some modules you are maintaining are being modified, check this out!

@dreispt dreispt linked an issue Apr 6, 2024 that may be closed by this pull request
account_invoice_margin: does not populate purchase_price on install #182
Open
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
@dreispt dreispt mentioned this pull request Aug 20, 2024
Open
@dreispt
Copy link
Member Author

dreispt commented Aug 22, 2024

@sergio-teruel Would you like to merge?

@dreispt
Copy link
Member Author

dreispt commented Aug 23, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-202-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 072d3f8 into OCA:14.0 Aug 23, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c089ea0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarcosg amarcosg amarcosg approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

account_invoice_margin: does not populate purchase_price on install
5 participants
@dreispt @OCA-git-bot @legalsylvain @sergio-teruel @amarcosg