From 0b11b08d40d183bb4b293289f65bab1aa879e5dd Mon Sep 17 00:00:00 2001
From: Martin Quinteros <maq@adhoc.com.ar>
Date: Thu, 7 Nov 2024 16:04:59 -0300
Subject: [PATCH] [FIX] document_url: Fix Download attachment component

Fix download atachment widget.

Document_url when activated causes error when opening attachment link on the chatter window
This commit (https://github.com/odoo/odoo/commit/366676cafdce00d55823c6daf41452b0c2373e4d) move download buttons into a sub-component.
I modified the module behavior to use canDownload() method instead of adding a t-if in the view and prevent the chatter component from breaking when the message has attachments.
---
 document_url/static/src/js/url.esm.js | 5 +++++
 document_url/static/src/xml/url.xml   | 6 ------
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/document_url/static/src/js/url.esm.js b/document_url/static/src/js/url.esm.js
index b11953e7043..2ecfb553696 100644
--- a/document_url/static/src/js/url.esm.js
+++ b/document_url/static/src/js/url.esm.js
@@ -52,6 +52,11 @@ patch(AttachmentList.prototype, {
      *
      * @returns {String}
      */
+    canDownload(attachment) {
+        return (
+            super.canDownload(attachment) && attachment.mimetype != "application/link"
+        );
+    },
     get attachmentUrl() {
         return url("/web/content", {
             id: this.attachment.id,
diff --git a/document_url/static/src/xml/url.xml b/document_url/static/src/xml/url.xml
index ce6793b61e5..be6b7ad3297 100644
--- a/document_url/static/src/xml/url.xml
+++ b/document_url/static/src/xml/url.xml
@@ -30,12 +30,6 @@
         </xpath>
     </t>
     <t t-inherit="mail.AttachmentList" t-inherit-mode="extension">
-        <xpath
-            expr="//div[contains(@class, 'o-mail-AttachmentCard-aside')]//button[@title='Download']"
-            position="attributes"
-        >
-            <attribute name="t-if">attachment.mimetype != 'application/link'</attribute>
-        </xpath>
         <xpath
             expr="//div[hasclass('o-mail-AttachmentCard-aside')]//button[@title='Download']"
             position="after"